New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621922 link

Starred by 3 users
Status: Fixed
Owner:
l...@chromium.org
Closed: May 2017
Cc:
█ kavvaru@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

GeoLocation changes are fired twice if Enter key is used

Reported by subsoni...@gmail.com, Jun 21 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2752.0 Safari/537.36

Steps to reproduce the problem:
1. Set up an event listener via `navigator.geolocation.watchPosition` that logs its arguments
2. In DevTool's GeoLocation emulation tab, type new coordinates into the inputs
3. Press enter while still being focused the input to apply the coordinates

What is the expected behavior?
Once the enter key is pressed or an input blurs, the event listener logs an event

What went wrong?
The event listener logs two events

Did this work before? N/A 

Chrome version: 53.0.2752.0  Channel: canary
OS Version: 53.0.2752.0
Flash Version: Shockwave Flash 21.0 r0

Comment 1 by kavvaru@chromium.org, Jun 22 2016

Cc: kavvaru@chromium.org
Labels: Needs-Feedback
subsonic17@ Thnaks for the issue.

Could you please provide us any sample test file or URL to triage the issue from test team end.

Thanks,

Comment 2 by subsoni...@gmail.com, Jun 22 2016 

Yes, certainly. Here's a test URL with detailed instructions on how to reproduce the bug.

https://jsfiddle.net/dgrsk23r/

Comment 3 by durga.behera@chromium.org, Jun 23 2016 

Thanks for the update, could you please help with a screen cast to further investigate it with a proper repro steps.
PFA the screen cast tried and let us know if any thing is missed here.
Note : You can use screen-O-Matic to record the steps.
621922_June_23.mp4
2.6 MB View Download

Comment 4 by subsoni...@gmail.com, Jun 23 2016 

@durga.behera It seems that your screencast is completely missing geolocation emulation. Please find attached a screencast that shows how the bug can be reproduced.

Just in case you're infamiliar with the device emulation functionality in DevTools, you can open the lower menu by pressing the `Esc` key.
geolocation-emulation-bug.mp4
1.7 MB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 23 2016

Labels: -Needs-Feedback Needs-Review
Owner: kavvaru@chromium.org
Thank you for providing more feedback. Adding requester "kavvaru@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by paulir...@chromium.org, Jul 1 2016

Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Sounds like we have multiple event handlers bound that are overlapping.

Comment 7 by cda...@chromium.org, Mar 13 2017

Labels: -Needs-Review
Cleaning up "Needs-Review" label as we are not using this label for triage anymore. Ref bug for this cleanup 684919
Project Member

Comment 8 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0fb333255e386d83f6d1b69d7239011e780ae4b

commit b0fb333255e386d83f6d1b69d7239011e780ae4b
Author: luoe <luoe@chromium.org>
Date: Mon May 01 21:50:02 2017

DevTools: pressing enter in bound input fields should not fire change handler

When a user modifies a bound input's text and presses Enter, the bound callback
would fire once on keydown and once on the following 'change' event.  This CL
prevents the default 'change' event from following up to avoid two calls.

BUG= 621922 

Review-Url: https://codereview.chromium.org/2843203003
Cr-Commit-Position: refs/heads/master@{#468433}

[modify] https://crrev.com/b0fb333255e386d83f6d1b69d7239011e780ae4b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Comment 9 by l...@chromium.org, May 8 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment