New issue
Advanced search Search tips

Issue 621919 link

Starred by 2 users
Status: Fixed
Owner:
lizeb@chromium.org
Closed: Jul 2016
Cc:
yus...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Bring back an improved ExternalPrerenderRequestTest.

Project Member Reported by lizeb@chromium.org, Jun 21 2016 
The test was removed in https://codereview.chromium.org/2086483004/:

Offline discussion: the best course of action is to remove this test, and bring it back in a better shape (no @UiThread tests, checking for the prerender start and completion, no sleep).
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b444ab1e097b919006a26ac03659470438d9d65

commit 5b444ab1e097b919006a26ac03659470438d9d65
Author: lizeb <lizeb@chromium.org>
Date: Thu Jul 21 17:32:49 2016

android: Add tests for ExternalPrerenderHandler.

Tests used to be there until
https://codereview.chromium.org/2086483004/, where they were
removed (since they weren't testing the right thing), to be re-added
later.

These tests don't run on the UI thread, and check that the prerender
actually starts and complete.

BUG= 621919 

Review-Url: https://codereview.chromium.org/2157033002
Cr-Commit-Position: refs/heads/master@{#406889}

[modify] https://crrev.com/5b444ab1e097b919006a26ac03659470438d9d65/chrome/android/java_sources.gni
[add] https://crrev.com/5b444ab1e097b919006a26ac03659470438d9d65/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

Comment 2 by lizeb@chromium.org, Jul 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment