createImageElement2.xhtml and pointer-events-image.svg flaky on Mac |
|||||
Issue descriptionhttps://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/33456/steps/webkit_tests/logs/stdio Regressions: Unexpected image-only failures (2) svg/custom/createImageElement2.xhtml [ Failure ] svg/custom/pointer-events-image.svg [ Failure ] Most often the tests fail, occasionally they pass.
,
Jun 21 2016
According to the flakiness dashboard, they are flaky on all platforms, not only on Mac on which the test was recently rebaselined: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=%20svg%2Fcustom%2FcreateImageElement2.xhtml%20svg%2Fcustom%2Fpointer-events-image.svg pdr@ can you take a look?
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c065affd6e62ba7e1658ace14f0d1186f789f503 commit c065affd6e62ba7e1658ace14f0d1186f789f503 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Jun 21 18:11:40 2016 Update expectations for bug 621915 , 617033 , 621892 BUG= 621915 , 617033 , 621892 Review URL: https://codereview.chromium.org/2086723003 . Cr-Commit-Position: refs/heads/master@{#401049} [modify] https://crrev.com/c065affd6e62ba7e1658ace14f0d1186f789f503/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 21 2016
,
Jun 21 2016
Both of these look like "opportunistic image loading" (image loads racing with test completion). I can take a stab at rewriting them tomorrow.
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14cf0aa6f21190351736e44ce017f18ae651c75c commit 14cf0aa6f21190351736e44ce017f18ae651c75c Author: fs <fs@opera.com> Date: Wed Jun 22 18:08:22 2016 Deflake svg/custom/pointer-events-image*.svg Rewrite these two tests (which are essentially the same, modulo a transform) to first wait for all the images to load, and then perform all the clicks. BUG= 621915 Review-Url: https://codereview.chromium.org/2088733006 Cr-Commit-Position: refs/heads/master@{#401343} [modify] https://crrev.com/14cf0aa6f21190351736e44ce017f18ae651c75c/third_party/WebKit/LayoutTests/svg/custom/pointer-events-image-css-transform.svg [modify] https://crrev.com/14cf0aa6f21190351736e44ce017f18ae651c75c/third_party/WebKit/LayoutTests/svg/custom/pointer-events-image.svg
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/461da15ac9dc2d59df3c88f9a56791199a802e70 commit 461da15ac9dc2d59df3c88f9a56791199a802e70 Author: fs <fs@opera.com> Date: Wed Jun 22 18:12:38 2016 Deflake svg/custom/createImageElement2.xhtml Need to wait for the image to load before ending the test. BUG= 621915 Review-Url: https://codereview.chromium.org/2086383002 Cr-Commit-Position: refs/heads/master@{#401347} [modify] https://crrev.com/461da15ac9dc2d59df3c88f9a56791199a802e70/third_party/WebKit/LayoutTests/svg/custom/createImageElement2.xhtml
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b74d6faa29cba82036d0ae2274fcfa78bede6890 commit b74d6faa29cba82036d0ae2274fcfa78bede6890 Author: fs <fs@opera.com> Date: Wed Jun 22 19:57:55 2016 Fix Mac10.9 baselines for two svg/custom/ tests Remove incorrect baselines for: svg/custom/createImageElement2.xhtml svg/custom/pointer-events-image.svg TBR=pdr@chromium.org NOTRY=true BUG= 621915 Review-Url: https://codereview.chromium.org/2082253004 Cr-Commit-Position: refs/heads/master@{#401387} [delete] https://crrev.com/18f8e78847f33a3ddcd979cd2f2ca952314de02a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/createImageElement2-expected.png [delete] https://crrev.com/18f8e78847f33a3ddcd979cd2f2ca952314de02a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/pointer-events-image-expected.png
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ca982bcdb01b8d539e62ae15b69cf53f55c3fa9 commit 5ca982bcdb01b8d539e62ae15b69cf53f55c3fa9 Author: fs <fs@opera.com> Date: Thu Jun 23 09:40:10 2016 Update expectations for crbug.com/621915 These tests no longer appear flaky: svg/custom/createImageElement2.xhtml svg/custom/pointer-events-image.svg svg/custom/pointer-events-image-css-transform.svg TBR=pdr@chromium.org BUG= 621915 Review-Url: https://codereview.chromium.org/2097443002 Cr-Commit-Position: refs/heads/master@{#401566} [modify] https://crrev.com/5ca982bcdb01b8d539e62ae15b69cf53f55c3fa9/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 23 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jun 21 2016