New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621903 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Non Regression:Learn more link is in disable mode in chrome://md-settings/syncSetup page.

Project Member Reported by bj00129...@techmahindra.com, Jun 21 2016

Issue description

Version: 53.0.2774.2 Dev
OS:Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome>>Signin with valid credentials>>navigate to  chrome://md-settings/syncSetup page>>Try to click on Learn more link in sync everything section and observe.

Expected:Learn more link should not be in disable mode.
Actual:Instead learn more link is disabled.

This is Non-Regression issue as it is seen from 53.0.2770.0 dev build.

Attaching screencast for reference.

 
Attaching screen-cast for reference.
Actual_Learnmore link in sync.ogv
513 KB View Download
Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
able to reproduce the issue on mac 10.11.5 using chrome version 53.0.2774.2
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 3 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by dpa...@chromium.org, Nov 17 2016

Labels: Proj-MaterialDesign-WebUI
Labels: -M-54 -MovedFrom-53 Hotlist-MD-Settings-People OS-Chrome
Owner: scottchen@chromium.org
Status: Assigned (was: Untriaged)
This is caused by the <a> link being inside a disabled <paper-checkbox>, and inheriting its css rule to ignore mouse events. 
dpapad and I experimented with some solutions:

1) we can specify a css rule to fix just on this page, for this specific link. This will allow us to fix the problem on our side very quickly for now. In our codebase we only have this one instance of link inside button-label.

2) If we think links inside checkboxes/radio-buttons might become more common, we could make a case with the Polymer authors that links should work inside disabled button-labels and make a PR to change it from source.

I'll be making a CL to execute 1), and we can optionally do 2) on an independent timeline.
Github issue for paper-checkbox created and can be tracked here: https://github.com/PolymerElements/paper-checkbox/issues/166
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d93ce395d082047e5b0d5d4ef038eeb3106beb22

commit d93ce395d082047e5b0d5d4ef038eeb3106beb22
Author: scottchen <scottchen@chromium.org>
Date: Fri Dec 09 18:48:01 2016

MD Settings: Make links inside disabled checkbox clickable on syncSetup page

BUG= 621903 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2563443005
Cr-Commit-Position: refs/heads/master@{#437597}

[modify] https://crrev.com/d93ce395d082047e5b0d5d4ef038eeb3106beb22/chrome/browser/resources/settings/people_page/sync_page.html

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on ChromeOS 9086.0.0, 57.0.2951.0

Sign in to add a comment