New issue
Advanced search Search tips

Issue 621889 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove ChromePrerenderService

Project Member Reported by lizeb@chromium.org, Jun 21 2016

Issue description

ChromePrerenderService is no longer used, remove the code (but keep the actual service to prevent potential old clients from crashing).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a373e507aca138969f45b92619ab29b6eae73033

commit a373e507aca138969f45b92619ab29b6eae73033
Author: lizeb <lizeb@chromium.org>
Date: Wed Jun 22 09:15:52 2016

Remove ChromePrerenderService, keeping only its skeleton behind.

ChromePrerenderService is no longer used, superseeded by (and partially
incompatible with) Custom Tabs. Remove the code, leaving only a skeleton
service behind, to prevent clients expecting it from having issues.

BUG= 621889 

Review-Url: https://codereview.chromium.org/2086483004
Cr-Commit-Position: refs/heads/master@{#401237}

[modify] https://crrev.com/a373e507aca138969f45b92619ab29b6eae73033/chrome/android/java/AndroidManifest.xml
[delete] https://crrev.com/c2fbb0f083499da42b6c4793108f689995cc4a5b/chrome/android/java/res/layout/prerender_test_main.xml
[modify] https://crrev.com/a373e507aca138969f45b92619ab29b6eae73033/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/a373e507aca138969f45b92619ab29b6eae73033/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java
[modify] https://crrev.com/a373e507aca138969f45b92619ab29b6eae73033/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/a373e507aca138969f45b92619ab29b6eae73033/chrome/android/java/src/org/chromium/chrome/browser/prerender/ChromePrerenderService.java
[delete] https://crrev.com/c2fbb0f083499da42b6c4793108f689995cc4a5b/chrome/android/java/src/org/chromium/chrome/browser/prerender/PrerenderAPITestActivity.java
[modify] https://crrev.com/a373e507aca138969f45b92619ab29b6eae73033/chrome/android/java_sources.gni
[delete] https://crrev.com/c2fbb0f083499da42b6c4793108f689995cc4a5b/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java
[delete] https://crrev.com/c2fbb0f083499da42b6c4793108f689995cc4a5b/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/PrerenderServiceTest.java

Comment 2 by lizeb@chromium.org, Jun 22 2016

Status: Fixed (was: Started)

Sign in to add a comment