New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621859 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Split Manifest::Icon and MediaMetadata::MediaImage

Project Member Reported by zqzh...@chromium.org, Jun 21 2016

Issue description

Now MediaMetadata uses Manifest::Icon as it's struct for artwork. We may need to move it to a common place.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 3 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-54 M-55
Labels: -M-55 M-56
zqzhang@, does this still apply?
Labels: -M-56 M-58
I think yes. Sorry I totally missed this.
Labels: -Pri-3 -MovedFrom-53 Pri-2
I guess this no longer applies. Manifest icons now have "purpose" and "platform" members, which are less useful for media icons. We probably need to split the two structures.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9387b26fd3057e265d2061d4063ec1634a32e5a

commit e9387b26fd3057e265d2061d4063ec1634a32e5a
Author: zqzhang <zqzhang@chromium.org>
Date: Tue Feb 07 10:46:44 2017

Split MediaMetadata::MediaImage from Manifest::Icon

Now Manifest::Icon has new members that doesn't apply to MediaImage. We
should split the two structs.

BUG= 621859 

Review-Url: https://codereview.chromium.org/2676493004
Cr-Commit-Position: refs/heads/master@{#448589}

[modify] https://crrev.com/e9387b26fd3057e265d2061d4063ec1634a32e5a/content/public/common/media_metadata.cc
[modify] https://crrev.com/e9387b26fd3057e265d2061d4063ec1634a32e5a/content/public/common/media_metadata.h

Status: Fixed (was: Assigned)
Summary: Split Manifest::Icon and MediaMetadata::MediaImage (was: Move the Icon struct (in content) to a common place)
The structs are split as Manifest::Icon now have new fields.
There's consideration of converging the icon structs from various Web APIs, but I think it should track this on spec issues instead of here.

Sign in to add a comment