Split Manifest::Icon and MediaMetadata::MediaImage |
||||||
Issue descriptionNow MediaMetadata uses Manifest::Icon as it's struct for artwork. We may need to move it to a common place.
,
Sep 6 2016
,
Oct 25 2016
,
Jan 4 2017
zqzhang@, does this still apply?
,
Jan 4 2017
I think yes. Sorry I totally missed this.
,
Jan 6 2017
,
Feb 3 2017
I guess this no longer applies. Manifest icons now have "purpose" and "platform" members, which are less useful for media icons. We probably need to split the two structures.
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9387b26fd3057e265d2061d4063ec1634a32e5a commit e9387b26fd3057e265d2061d4063ec1634a32e5a Author: zqzhang <zqzhang@chromium.org> Date: Tue Feb 07 10:46:44 2017 Split MediaMetadata::MediaImage from Manifest::Icon Now Manifest::Icon has new members that doesn't apply to MediaImage. We should split the two structs. BUG= 621859 Review-Url: https://codereview.chromium.org/2676493004 Cr-Commit-Position: refs/heads/master@{#448589} [modify] https://crrev.com/e9387b26fd3057e265d2061d4063ec1634a32e5a/content/public/common/media_metadata.cc [modify] https://crrev.com/e9387b26fd3057e265d2061d4063ec1634a32e5a/content/public/common/media_metadata.h
,
Feb 15 2017
The structs are split as Manifest::Icon now have new fields. There's consideration of converging the icon structs from various Web APIs, but I think it should track this on spec issues instead of here. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sheriffbot@chromium.org
, Jul 3 2016