New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621856 link

Starred by 20 users
Status: Fixed
Owner:
clamy@chromium.org
Closed: Nov 2016
Cc:
creis@chromium.org
█ nasko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 694688
issue 470669
issue 653807



Sign in to add a comment

Have WCO::ReadyToCommitNavigation work on current architecture

Project Member Reported by clamy@chromium.org, Jun 21 2016 
WCO::ReadyToCommitNavigation was introduced to provide a point in time at which the RenderFrameHost that will navigate is known. Currently it only works with PlzNavigate. A certain number of components would benefit from having it working in the current architecture as well.

In order to do this, we first have to complete the move of the mime sniffing at the beginning of the ResourceHandler chain (see https://codereview.chromium.org/2005273002/#ps160001). Then we plan on merging the CrossSiteResourceHandler with the NavigationResourceThrottle, and take advantage of the IO-UI roundtrip we're making in NavigationResourceThrottle::OnWillProcessResponse to make the decision about whether to transfer the navigation or not there.

Comment 1 by chrishtr@chromium.org, Jun 21 2016

Blocking: 470669

Comment 2 by chrishtr@chromium.org, Jul 22 2016 

Hi Camille,

Any update on this? Does it still seem on track for finishing this month or so?

Comment 3 by clamy@chromium.org, Jul 25 2016 

I'm still working on it, but the necessary CLs to land took a bit more time than expected. Since I'm going to be ooo for 2 weeks, end of August seems a more reasonnable time frame.

Comment 4 by chrishtr@chromium.org, Jul 27 2016 

Ok cool. Thanks for the update.

Comment 5 by sweep...@gmail.com, Sep 5 2016 

As this is blocking  issue 470669  - I would like to refer to https://bugs.chromium.org/p/chromium/issues/detail?id=470669#c122
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbf524d4ff19eb202e4ff67810f1909e05b52849

commit cbf524d4ff19eb202e4ff67810f1909e05b52849
Author: clamy <clamy@chromium.org>
Date: Tue Sep 27 12:48:35 2016

Create NavigationHandles for interstitials if needed

On Android, navigations for interstitials go through the network stack.
Not having a NavigationHandle for them prevents us from enforcing that
every navigation has a NavigationHandle. This CL fixes and adds this
requirement.

BUG= 621856 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2364943002
Cr-Commit-Position: refs/heads/master@{#421184}

[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/frame_host/interstitial_page_navigator_impl.cc
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/frame_host/interstitial_page_navigator_impl.h
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/frame_host/navigator.cc
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/frame_host/navigator.h
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/frame_host/navigator_delegate.cc
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/frame_host/navigator_delegate.h
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/frame_host/navigator_impl.h
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/loader/DEPS
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/loader/navigation_resource_throttle.cc
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/loader/navigation_resource_throttle.h
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/cbf524d4ff19eb202e4ff67810f1909e05b52849/content/browser/web_contents/web_contents_impl.h
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f40a0349f8575ccd544d6844dccd56119b87170c

commit f40a0349f8575ccd544d6844dccd56119b87170c
Author: clamy <clamy@chromium.org>
Date: Tue Sep 27 15:23:24 2016

Merge CrossSiteResourceHandler and NavigationResourceThrottle

This CL merges CrossSiteResourceHandler and NavigationResourceThrottle.
It also removes the CrossSiteResourceRequest in favor of using
NavigationHandle. This allows WebContentsObserver::ReadyToCommit
navigation to be called in the non-PlzNavigate architecture.

A detailed description of the change can be found at https://docs.google.com/a/chromium.org/document/d/1Ze5_RNvUQV4ltWvFU5MY3L_TRIAux88iLadQIPHTMqk/edit?usp=sharing.

BUG= 621856 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2321543002
Cr-Commit-Position: refs/heads/master@{#421216}

[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/BUILD.gn
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/devtools/render_frame_devtools_agent_host.cc
[delete] https://crrev.com/9d13729984128b2970874d8f729ff5f77cd1158e/content/browser/frame_host/cross_site_transferring_request.cc
[delete] https://crrev.com/9d13729984128b2970874d8f729ff5f77cd1158e/content/browser/frame_host/cross_site_transferring_request.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/frame_host/render_frame_host_manager_unittest.cc
[delete] https://crrev.com/9d13729984128b2970874d8f729ff5f77cd1158e/content/browser/loader/cross_site_resource_handler.cc
[delete] https://crrev.com/9d13729984128b2970874d8f729ff5f77cd1158e/content/browser/loader/cross_site_resource_handler.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/loader/navigation_resource_throttle.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/loader/navigation_resource_throttle.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/loader/resource_loader.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/public/browser/content_browser_client.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/f40a0349f8575ccd544d6844dccd56119b87170c/content/shell/browser/shell_content_browser_client.h

Comment 8 by clamy@chromium.org, Sep 27 2016 

With https://codereview.chromium.org/2321543002 landing, WCO::ReadyToCommitNavigation should now work on the current architecture. I'll mark this as fixed in a few days if the patch sticks.

Comment 9 by csharrison@chromium.org, Sep 27 2016 

Awesome :)

Can I ask, at this point in the navigation, how much data have we read off the request?

Comment 10 by chrishtr@chromium.org, Sep 27 2016 

Cool!

Comment 11 by nasko@chromium.org, Sep 27 2016 

About comment #9, this is dispatched after enough data is read from the network to determine this will be a document we want to render (as opposed to 204, download, etc). This includes the headers and a bit of content for mime sniffing.

Once it is known it will be a document, we pick a RenderFrameHost that will render it and dispatch WCO::ReadyToCommitNavigation right before we allow the RenderFrameHost to commit.
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42ac3af0382dff192c3bc9f90f37a3982822bbb0

commit 42ac3af0382dff192c3bc9f90f37a3982822bbb0
Author: Nasko Oskov <nasko@chromium.org>
Date: Wed Oct 05 23:51:11 2016

Revert the merge of CrossSiteResourceHandler and NavigationResourceThrottle.

The merge between those two objects was done over more than one CL. The
goal of this CL is to revert all of the code at once, so it can be easily
relanded once the branch cut happens.

This CL reverts the following two:

Revert "Merge CrossSiteResourceHandler and NavigationResourceThrottle"
This reverts commit f40a0349f8575ccd544d6844dccd56119b87170c.

Revert "Prevent RFH from attempting to transfer after it's been swapped out"
This reverts commit 152381c57c5c04d07b9ebb2496e369ba239a98f7.

BUG= 621856 , 651503
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
R=creis@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/2397893002 .

Cr-Commit-Position: refs/heads/master@{#423343}

[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/test/data/extensions/api_test/webnavigation/crossProcessAbort/test_crossProcessAbort.js
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/BUILD.gn
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/devtools/render_frame_devtools_agent_host.cc
[add] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/cross_site_transferring_request.cc
[add] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/cross_site_transferring_request.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/render_frame_host_manager_unittest.cc
[add] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/cross_site_resource_handler.cc
[add] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/cross_site_resource_handler.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/navigation_resource_throttle.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/navigation_resource_throttle.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_loader.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/public/browser/content_browser_client.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/public/test/browser_test_utils.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/shell/browser/shell_content_browser_client.h

Comment 13 by melandory@chromium.org, Oct 7 2016

Blocking: 653807
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d69748c97ae3e11a2611f498b745fd6fc5b5f301

commit d69748c97ae3e11a2611f498b745fd6fc5b5f301
Author: clamy <clamy@chromium.org>
Date: Fri Oct 07 22:09:44 2016

Reland "Merge of CrossSiteResourceHandler and NavigationResourceThrottle."

This relands https://codereview.chromium.org/2321543002/ that was
reverted by https://codereview.chromium.org/2397893002/. The original
was reverted because it landed to close to branch point, and we want to
give it more time on the dev branch to fix issues that can potentially
arise.

This CL relands it now that the branch has been cut.

BUG= 621856 
TBR=sky@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2392283005
Cr-Commit-Position: refs/heads/master@{#423979}

[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/chrome/test/data/extensions/api_test/webnavigation/crossProcessAbort/test_crossProcessAbort.js
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/BUILD.gn
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/devtools/render_frame_devtools_agent_host.cc
[delete] https://crrev.com/2f545df32a684b115b8b4c5458778695881b1bc6/content/browser/frame_host/cross_site_transferring_request.cc
[delete] https://crrev.com/2f545df32a684b115b8b4c5458778695881b1bc6/content/browser/frame_host/cross_site_transferring_request.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/frame_host/render_frame_host_manager_unittest.cc
[delete] https://crrev.com/2f545df32a684b115b8b4c5458778695881b1bc6/content/browser/loader/cross_site_resource_handler.cc
[delete] https://crrev.com/2f545df32a684b115b8b4c5458778695881b1bc6/content/browser/loader/cross_site_resource_handler.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/loader/navigation_resource_throttle.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/loader/navigation_resource_throttle.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/loader/resource_loader.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/public/browser/content_browser_client.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/public/test/browser_test_utils.h
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/d69748c97ae3e11a2611f498b745fd6fc5b5f301/content/shell/browser/shell_content_browser_client.h

Comment 15 by clamy@chromium.org, Oct 10 2016 

Update on the NavigationHandle being present in case of a transfer navigation: it appears it is simply a new one created following a DidStartProvisionalLoad from the renderer pending swap out. I thought we were filtering out those messages, but it turns out that we don't.
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea67b131fe91c553c319964f809c42d06d9786b3

commit ea67b131fe91c553c319964f809c42d06d9786b3
Author: clamy <clamy@chromium.org>
Date: Tue Oct 11 11:42:53 2016

Do not create NavigationHandles for inactive RenderFrameHosts

This CL ensures that no NavigationHandle will be created in a
RenderFrameHost that is no longer active. This also fixes a similar
issue in PlzNavigate, where a renderer that is no longer active could
start a navigation.

BUG= 621856 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2403813002
Cr-Commit-Position: refs/heads/master@{#424405}

[modify] https://crrev.com/ea67b131fe91c553c319964f809c42d06d9786b3/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/ea67b131fe91c553c319964f809c42d06d9786b3/content/browser/frame_host/render_frame_host_manager_unittest.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42ac3af0382dff192c3bc9f90f37a3982822bbb0

commit 42ac3af0382dff192c3bc9f90f37a3982822bbb0
Author: Nasko Oskov <nasko@chromium.org>
Date: Wed Oct 05 23:51:11 2016

Revert the merge of CrossSiteResourceHandler and NavigationResourceThrottle.

The merge between those two objects was done over more than one CL. The
goal of this CL is to revert all of the code at once, so it can be easily
relanded once the branch cut happens.

This CL reverts the following two:

Revert "Merge CrossSiteResourceHandler and NavigationResourceThrottle"
This reverts commit f40a0349f8575ccd544d6844dccd56119b87170c.

Revert "Prevent RFH from attempting to transfer after it's been swapped out"
This reverts commit 152381c57c5c04d07b9ebb2496e369ba239a98f7.

BUG= 621856 , 651503
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
R=creis@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/2397893002 .

Cr-Commit-Position: refs/heads/master@{#423343}

[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/chrome/test/data/extensions/api_test/webnavigation/crossProcessAbort/test_crossProcessAbort.js
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/BUILD.gn
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/devtools/render_frame_devtools_agent_host.cc
[add] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/cross_site_transferring_request.cc
[add] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/cross_site_transferring_request.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/frame_host/render_frame_host_manager_unittest.cc
[add] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/cross_site_resource_handler.cc
[add] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/cross_site_resource_handler.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/navigation_resource_throttle.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/navigation_resource_throttle.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_loader.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/public/browser/content_browser_client.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/public/test/browser_test_utils.h
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/42ac3af0382dff192c3bc9f90f37a3982822bbb0/content/shell/browser/shell_content_browser_client.h

Comment 18 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Comment 19 by clamy@chromium.org, Nov 9 2016

Status: Fixed (was: Assigned)
This time it seems the change is sticking, so I'm closing this.
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/669ebe761301d962d5c0540bb7d8e2cfe836a81e

commit 669ebe761301d962d5c0540bb7d8e2cfe836a81e
Author: scottmg <scottmg@chromium.org>
Date: Thu Feb 23 00:36:19 2017

Remove DumpWithoutCrashing() from RFHI::SetNavigationHandle

Semi-related bug is marked fixed. Part of trying to rationalize all
calls to DumpWithoutCrashing().

R=clamy@chromium.org
BUG= 621856 ,694688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2708043003
Cr-Commit-Position: refs/heads/master@{#452309}

[modify] https://crrev.com/669ebe761301d962d5c0540bb7d8e2cfe836a81e/content/browser/frame_host/render_frame_host_impl.cc

Comment 21 by scottmg@chromium.org, Feb 23 2017

Blocking: 694688
►

Sign in to add a comment