Regression: In chrome://downloads focus highlight on iron icon vanish after hitting 'Esc' key.
Reported by
rk...@etouch.net,
Jun 21 2016
|
||||
Issue descriptionChrome Version: 53.0.2774.2 Revision 284c900d4fedb00148839403af374758df95029f-refs/branch-heads/2774@{#4} OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch chrome,navigate to chrome://downloads and resize the browser window. (2) Click on iron icon(More options overlay opened),press Esc key(Focus highlight stays on iron icon) (3) Hitt Enter key (More option overlay opened) and press Esc key observe. Focus highlight vanish after step 3, but on hitting 'Enter' key More options overlay gets opened. Focus highlight should not stay after hitting 'Esc' key or it should stays always. This is a regression issue, broken in 'M-53', below is bisect info: Good Build: 53.0.2769.0 Bad Build: 53.0.2770.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/12d2dbad0b4764b9740531fc708f8f843bbe2513..7f5c588722c9f0a3b0c0a8f1bee0726241170c52?pretty=fuller&n=100 Suspecting: r400281
,
Jun 27 2016
Issue still seen on 53.0.2780.0. dbeam@: Could you please take a look into this and update further.
,
Jul 4 2016
Able to reproduce the issue on windows 7 using chrome version 54.0.2787.0. dbeam@ Please look into this issue. Thanks,
,
Jul 11 2016
Still able to reproduce the issue on windows 7 using chrome version latest M-53(53.0.2785.8) and M-54(54.0.2793.0). dbeam@ Could you please look into this issue. Thanks,
,
Jul 16 2016
,
Jul 18 2016
,
Jul 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe4e4fd043521a2509ab76a3c23973f0683ad362 commit fe4e4fd043521a2509ab76a3c23973f0683ad362 Author: dbeam <dbeam@chromium.org> Date: Mon Jul 18 08:07:59 2016 MD Downloads: rework "more actions" menu focus handling code 1) Hide the menu if focus moves outside of the menu 2) Don't /always/ restore focus to the <paper-menu-button> R=tsergeant@chromium.org BUG= 621842 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2153323002 Cr-Commit-Position: refs/heads/master@{#405965} [modify] https://crrev.com/fe4e4fd043521a2509ab76a3c23973f0683ad362/chrome/browser/resources/md_downloads/compiled_resources2.gyp [modify] https://crrev.com/fe4e4fd043521a2509ab76a3c23973f0683ad362/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/fe4e4fd043521a2509ab76a3c23973f0683ad362/chrome/browser/resources/md_downloads/toolbar.html [modify] https://crrev.com/fe4e4fd043521a2509ab76a3c23973f0683ad362/chrome/browser/resources/md_downloads/toolbar.js [modify] https://crrev.com/fe4e4fd043521a2509ab76a3c23973f0683ad362/chrome/browser/resources/md_downloads/vulcanized.html
,
Jul 18 2016
the new behavior is: if Escape is used to choose the menu, focus should return to the vertical dots button. if Tab is used to focus outside the menu, focus should move to the next focusable item (and not be usurped by the vertical dots button). if a click or tap closes the menu (either by selecting an action or tap/click outside to close): I don't care what happens to focus. |
||||
►
Sign in to add a comment |
||||
Comment 1 by tkonch...@chromium.org
, Jun 21 2016