Regression: Unnecessary focus stays on user profile icon of 'Switch person' overlay after pressing 'Esc' key.
Reported by
rk...@etouch.net,
Jun 21 2016
|
||||
Issue descriptionChrome Version: 53.0.2773.0 Revision ced2fcee2c85702055d028f4e3e48c5a75a7e41c-refs/heads/master@{#400610}(32/64 bit) OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, click on avatar icon and select 'Switch person' option. (2) Click on drop down of profile,then press 'Esc' and observe. Unnecessary focus stays on user profile icon after pressing 'Esc' key. Focus should not stays on user profile icon after pressing 'Esc' key. This is a regression issue, broken in 'M-53', below is bisect info: Good Build: 53.0.2767.0 Bad Build: 53.0.2769.2 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/dca42159c2b19c25f033ff6e5e0da8d70a491576..e2fa57eacaf6a1a8f0fd8449603e29e647b183c2?pretty=fuller&n=100 Suspecting: r399754 ? @yiyaoliu: Please help me reassign this issue if your change is not cause for it.
,
Jun 21 2016
Adding RB label as this is a recent regression
,
Jun 21 2016
glevin@ this seems to be user pod related. Could it have been caused by your CL?
,
Jun 22 2016
This was almost certainly caused by my CL. However, I am not convinced that this change is a bug or undesirable, and in fact, I believe it to be an improvement. On a browser version 53.0.2767.0 (before my change), try the following two things, after opening the "Switch person" window... Thing the First: Do: Click to open the profile menu, hover the pointer over the menu, and then press ESC. Observe: Sometimes, but not always, the menu is closed but the pod retains focus (in Expected_Behaviour.mp4 above, the cursor is always moved off the menu before ESC is pressed). Thing the Second: Do: TAB until focus is on some pod's menu icon. Press ENTER to open menu, then ESC to close it. Observe: The pod retains focus. The behavior in Expected_Behaviour.mp4 is inconsistent with these other previously existing behaviors; Actual_Behavoiur.mp4 shows consistent behavior, where ESC *only* closes the menu, and doesn't de-focus the pod. My feeling is that this is correct UI behavior, and that ESC should only close/de-focus/undo one UI element at a time, and not several layers simultaneously. If someone feels that ESC doing both at once is the preferred behavior, then I'm happy to fix the results of my CL, and change the existing behaviors of Things the First and Second as well. If there were any harm in the pod remaining focused (e.g., if some action then required an extra click or key press), then I might even prefer that change. However, since it seems (to me) that this change is actually improving consistency rather than degrading behavior, I'm going to mark this as "Won't Fix (working as intended)". Please reopen if you disagree, and I'll fix it. NOTE: Same behavior (before and after my CL) also seen on user pods on Chrome OS login page. |
||||
►
Sign in to add a comment |
||||
Comment 1 by yiyaoliu@chromium.org
, Jun 21 2016Owner: mahmadi@chromium.org