Issue metadata
Sign in to add a comment
|
Chromebook lock screen password field has blinking cursor but focus is on httpauth dialog
Reported by
realgran...@gmail.com,
Jun 21 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 8172.47.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Platform: 8172.47.0 (Official Build) stable-channel falco Steps to reproduce the problem: 1. open a website that will navigate to a httpauth page after delay, like http://doc.plotti.co/r.html 2. close the lid (lock option set), wait for redirect 10 seconds 3. open the lid, try to type password and log in What is the expected behavior? I am able to type password in the password field What went wrong? password is instead typed into httpauth form, while cursor shows like focus is in password field Did this work before? N/A Chrome version: 51.0.2704.79 Channel: n/a OS Version: 8172.47.0 Flash Version: Shockwave Flash 21.0 r0
,
Jun 22 2016
this may be related to crbug.com/620406 that I noticed recently. Let me look into this first.
,
Jun 24 2016
Actually, this is different from crbug.com/620406 . Here is what's happening 1) view's FocusManager sets the Focus to the view and calls OnFocus, even though its window does not have a focus 2) chromeos (ash) correctly rejects activating and focusing the window behind lock screen. 3) chromeos (ash) correctly select the lock window as a target for key events 4) InputMethodChromeOS receives this event, but send it to the wrong client set in 1), even though the target is different. warx@, can you work on fixing 1) I'll explain how. 4) is also needs to be fixed because calling just SetFocusedTextInputClient will lead to the similar problem. shuchen@, I think it needs to reject the event if it's sent to the different target. Can you or someone in your team work on 4)? I think it just need to get native window from client and make sure it can receive events.
,
Jun 28 2016
,
Jul 8 2016
From #1, it looks like this bug is a regression? Would a bisect help here?
,
Sep 27 2016
,
Sep 27 2016
,
Oct 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c16e0e849526c1c627e08a05351ab38a9cfbcf1 commit 5c16e0e849526c1c627e08a05351ab38a9cfbcf1 Author: warx <warx@chromium.org> Date: Fri Oct 21 21:55:46 2016 Do not give instant focus if a view's toplevelwidget is not active If the top level widget isn't active during setting focus view, we store the focused view and then attempt to activate the widget. If activation succeeds view will be focused. If activation fails |view| will be focused the next time the widget is made active. Based on this rule, a set of unittests related are modified. This is a following up CL for 2113163002 as there are already too many patches there. BUG= 621791 BUG= 650776 BUG= 152938 TEST=add an interactive_ui_test, NativeWidgetAuraTest.NonActiveWindowRequestImeFocus Review-Url: https://chromiumcodereview.appspot.com/2371113003 Cr-Commit-Position: refs/heads/master@{#426905} [modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ash/common/system/tray/tray_details_view_unittest.cc [modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc [modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc [delete] https://crrev.com/b07f20559996aa8154a3a67e742676a9799e37c4/chrome/browser/ui/views/toolbar/toolbar_view_browsertest.cc [modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc [modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/chrome/test/BUILD.gn [modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/controls/combobox/combobox_unittest.cc [modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/focus/focus_manager.cc [modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/mus/native_widget_mus.cc [modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/view_targeter_unittest.cc [modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [add] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/widget/native_widget_aura_interactive_uitest.cc [modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/widget/root_view_unittest.cc
,
Oct 21 2016
pass the issue to shuchen@ for comment 3(4)
,
Jan 13 2017
Re #3, oshima@, can you please point out the code points where FocusManager calls view's OnFocus? I don't think it is a good idea to make implementations (e.g. InputMethodChromeOS) directly depend on aura/views. I would recommend to let FocusManager avoid calling SetFocusedTextInputClient() when the window is not activated (at front).
,
Feb 22 2017
oshima@, can you please address #10? Thanks.
,
Nov 19
<triage> Cannot reproduce on 72.0.3593.0, please reopen if seen again. </triage> |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dominickn@chromium.org
, Jun 22 2016Labels: -Type-Bug-Security -Restrict-View-SecurityTeam Type-Bug-Regression
Owner: osh...@chromium.org