New issue
Advanced search Search tips

Issue 621778 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

WakeLock browser tests sleep()

Project Member Reported by ben@chromium.org, Jun 21 2016

Issue description

https://chromium.googlesource.com/chromium/src/+/master/content/browser/wake_lock/wake_lock_browsertest.cc#80

These tests are sleeping to "resolve" asynchronous responses from the renderer. We should never ever ever do this as it is a source of flake.

Instead, these tests should use a test API to listen for state changes in the WakeLockServiceContext, and spin a runloop until state change occurs.


 

Comment 1 by ben@chromium.org, Jun 21 2016

Labels: -Pri-3 Pri-2
Components: Test

Sign in to add a comment