New issue
Advanced search Search tips

Issue 621774 link

Starred by 2 users
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 607761



Sign in to add a comment

Android Lint: third_party libraries should be ignored

Project Member Reported by agrieve@chromium.org, Jun 21 2016 
To see these warnings, build:
//chrome/android:chrome_java

E.g.:
third_party/android_tools/sdk/extras/android/support/v7/mediarouter/res/layout/mr_chooser_list_item.xml:26 [Accessibility] Missing `contentDescription` attribute on image: ContentDescription [warning]
    <ImageView android:id="@+id/mr_chooser_route_icon"

We just need to add "chromium_code=false" to the BUILD.gn file.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d08fe288cd840f2505dbd083fc9d75db82582d05

commit d08fe288cd840f2505dbd083fc9d75db82582d05
Author: agrieve <agrieve@chromium.org>
Date: Wed Jun 29 20:36:14 2016

Default chromium_code = false for Android targets within third_party

This affects the following:
  //third_party/jmake:jmake
  //third_party/jsr-305:jsr_305_javalib
  //third_party/gif_player:gif_player_java
  //third_party/leakcanary:leakcanary_noop_java

BUG= 621774 
TBR=yusufo

Review-Url: https://codereview.chromium.org/2103273002
Cr-Commit-Position: refs/heads/master@{#402926}

[modify] https://crrev.com/d08fe288cd840f2505dbd083fc9d75db82582d05/build/config/android/internal_rules.gni
[modify] https://crrev.com/d08fe288cd840f2505dbd083fc9d75db82582d05/third_party/custom_tabs_client/BUILD.gn

Comment 2 by agrieve@chromium.org, Jul 1 2016

Status: Started (was: Available)
Rest of the fix is here: https://codereview.chromium.org/2113943002/#
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a12be529fb88039cc3090a83c4fbaaf04e13b144

commit a12be529fb88039cc3090a83c4fbaaf04e13b144
Author: agrieve <agrieve@chromium.org>
Date: Mon Jul 04 15:40:21 2016

Rework Android resource linting to exclude third_party

The existing assumption in the code (that the existense of package name
within android_resource() rules determines whether they should be
linted) turned out to be false.

The new logic does not look at package names, but instead collects all
reference resources, and then excludes any of them that were already
linted by another android_library().

BUG= 621774 

Review-Url: https://codereview.chromium.org/2113943002
Cr-Commit-Position: refs/heads/master@{#403687}

[modify] https://crrev.com/a12be529fb88039cc3090a83c4fbaaf04e13b144/build/android/gyp/write_build_config.py
[modify] https://crrev.com/a12be529fb88039cc3090a83c4fbaaf04e13b144/build/config/android/internal_rules.gni
[modify] https://crrev.com/a12be529fb88039cc3090a83c4fbaaf04e13b144/build/config/android/rules.gni

Comment 4 by agrieve@chromium.org, Jul 4 2016

Status: Fixed (was: Started)
►

Sign in to add a comment