New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621772 link

Starred by 4 users
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Jul 2016
Cc:
█ ainslie@chromium.org
█ rolfe@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 607761



Sign in to add a comment

Android lint has many TypographyEllipsis warnings for chrome_java

Project Member Reported by agrieve@chromium.org, Jun 21 2016 
There's about 500 of them.

They appear when building:
//chrome/android:chrome_java

E.g.:
../../../../../../tmp/tmpd3ZOHh/r3/values-de/android_chrome_strings.xml:60 Replace "..." with ellipsis character (…, …) ?: TypographyEllipsis [warning]
<string name="section_saved_passwords_exceptions">"Nie speichern für..."</string>

Comment 1 by agrieve@chromium.org, Jul 1 2016

Status: Started (was: Available)
In progress here: https://codereview.chromium.org/2112653003/

Comment 2 by agrieve@chromium.org, Jul 4 2016 

Attached image of change on Ubuntu. Notice Cast... is still using three periods and looks a bit different. Print and Find are using &#8230;
Screen Shot 2016-07-04 at 11.28.45 AM.png
20.5 KB View Download

Comment 3 by jochen@chromium.org, Jul 5 2016

Cc: ainslie@chromium.org
Alex, wdyt?

Comment 4 by ainslie@chromium.org, Jul 6 2016

Cc: rolfe@chromium.org
From the image in #2, I had trouble spotting the difference. So my gut reaction is that we should just pick one and be consistent. rolfe@, WDYT?

Comment 5 by agrieve@chromium.org, Jul 11 2016 

Here's mac before & after. I can't tell the difference so I suspect there's no rendering change between them. They top menus also look identical.
Screen Shot 2016-07-11 at 12.39.20 PM.png
14.6 KB View Download
Screen Shot 2016-07-11 at 12.39.47 PM.png
11.3 KB View Download

Comment 6 by agrieve@chromium.org, Jul 11 2016 

Here's IE's extended menu vs. Chrome's with the change. Also can't see a difference.
Screen Shot 2016-07-11 at 12.48.11 PM.png
15.2 KB View Download
Screen Shot 2016-07-11 at 12.44.41 PM.png
10.7 KB View Download

Comment 7 by rolfe@chromium.org, Jul 11 2016 

Somewhat related bug for Android:
https://bugs.chromium.org/p/chromium/issues/detail?id=554223

Decision was to use the ellipsis characters rather than three-manual dots. I agree with ainslie@ it's nicest if they just all match, but perhaps that helps with precedent.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e82c4e1b9de3b189c85bccff63d4ef3046e44d43

commit e82c4e1b9de3b189c85bccff63d4ef3046e44d43
Author: agrieve <agrieve@chromium.org>
Date: Fri Jul 22 17:10:57 2016

grit: Automatically replace ... with … (U+2026)

Android lint tool pointed out that ... should really be … (U+2026).
Tested that this glyph renders well on Mac + Win as well, so
applying to all OS's by default.

TBR=flackr
BUG= 621772 

Review-Url: https://codereview.chromium.org/2112653003
Cr-Commit-Position: refs/heads/master@{#407182}

[modify] https://crrev.com/e82c4e1b9de3b189c85bccff63d4ef3046e44d43/chrome/browser/download/download_item_model_unittest.cc
[modify] https://crrev.com/e82c4e1b9de3b189c85bccff63d4ef3046e44d43/tools/grit/grit/node/message.py
[modify] https://crrev.com/e82c4e1b9de3b189c85bccff63d4ef3046e44d43/tools/grit/grit/node/message_unittest.py
[modify] https://crrev.com/e82c4e1b9de3b189c85bccff63d4ef3046e44d43/tools/grit/grit/tool/build.py
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3838bf20b26e5dd0d5f83ea8c2215d359d8e19b

commit a3838bf20b26e5dd0d5f83ea8c2215d359d8e19b
Author: mpearson <mpearson@chromium.org>
Date: Fri Jul 22 18:52:10 2016

Revert of grit: Automatically replace ... with … (patchset #10 id:180001 of https://codereview.chromium.org/2112653003/ )

Reason for revert:
Likely cause of failures:

---
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/67858

unexpected_failures:
fast/forms/color/color-suggestion-picker-appearance-zoom125.html
fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html
fast/forms/color/color-suggestion-picker-appearance-zoom200.html

all with the message
image diff
---

since it appears to replace "..." with a proper ellipsis, which all the three
tests show differences from:

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/67858/layout-test-results/results.html

also failures for

also some other bots for tests
fast/forms/color/color-suggestion-picker-appearance.html
fast/forms/color/color-suggestion-picker-one-row-appearance.html
fast/forms/color/color-suggestion-picker-two-row-appearance.html
appear on other bots.

And, for what it's worth,
the bot
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3384
started showing a renderer crash in
http/tests/images/restyle-decode-error.html
in a blamelist that includes this change as well.  Hopefully this revert will fix that too. :-)

Original issue's description:
> grit: Automatically replace ... with … (U+2026)
>
> Android lint tool pointed out that ... should really be … (U+2026).
> Tested that this glyph renders well on Mac + Win as well, so
> applying to all OS's by default.
>
> TBR=flackr
> BUG= 621772 
>
> Committed: https://crrev.com/e82c4e1b9de3b189c85bccff63d4ef3046e44d43
> Cr-Commit-Position: refs/heads/master@{#407182}

TBR=flackr@chromium.org,asanka@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 621772 

Review-Url: https://codereview.chromium.org/2176663003
Cr-Commit-Position: refs/heads/master@{#407219}

[modify] https://crrev.com/a3838bf20b26e5dd0d5f83ea8c2215d359d8e19b/chrome/browser/download/download_item_model_unittest.cc
[modify] https://crrev.com/a3838bf20b26e5dd0d5f83ea8c2215d359d8e19b/tools/grit/grit/node/message.py
[modify] https://crrev.com/a3838bf20b26e5dd0d5f83ea8c2215d359d8e19b/tools/grit/grit/node/message_unittest.py
[modify] https://crrev.com/a3838bf20b26e5dd0d5f83ea8c2215d359d8e19b/tools/grit/grit/tool/build.py
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb4ce774fbeafec4daa9e63cce9afaf877e30c09

commit cb4ce774fbeafec4daa9e63cce9afaf877e30c09
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Jul 25 21:08:53 2016

Auto-rebaseline for r407548

https://chromium.googlesource.com/chromium/src/+/706d93d0d

BUG= 621772 
TBR=agrieve@chromium.org

Review URL: https://codereview.chromium.org/2182753002 .

Cr-Commit-Position: refs/heads/master@{#407571}

[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/color/color-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/win/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/win/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/win/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
[add] https://crrev.com/cb4ce774fbeafec4daa9e63cce9afaf877e30c09/third_party/WebKit/LayoutTests/platform/win7/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png

Comment 12 by vabr@chromium.org, Jul 26 2016 

Since the rebaseline in #11, fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html keeps failing consistently on my Linux machine and on bots as well (e.g., https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/21341, stdio attached). I will update the test expectations.
Log File contents.html
7.7 MB View Download

Comment 13 by agrieve@chromium.org, Jul 26 2016 

Thanks!
Tried to do so myself last night, but it seems there's something fishy going on with scroll bars:
https://codereview.chromium.org/2177993004/

Comment 14 by vabr@chromium.org, Jul 26 2016 

Thanks for the link. It is strange, it seemed flaky on the bots, but locally I could reproduce, so I went for disabling.

Comment 15 by agrieve@chromium.org, Jul 26 2016 

SGTM.
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89c163417d6da1c2d8c684ed871342bd5584385d

commit 89c163417d6da1c2d8c684ed871342bd5584385d
Author: vabr <vabr@chromium.org>
Date: Tue Jul 26 15:43:01 2016

Disable fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html

BUG= 621772 
TBR=agrieve@chromium.org

Review-Url: https://codereview.chromium.org/2182733003
Cr-Commit-Position: refs/heads/master@{#407809}

[modify] https://crrev.com/89c163417d6da1c2d8c684ed871342bd5584385d/third_party/WebKit/LayoutTests/TestExpectations

Comment 17 by agrieve@chromium.org, Jul 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment