New issue
Advanced search Search tips

Issue 621771 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 607761



Sign in to add a comment

restriction_values.xml causing ~300 "is not translated" lint warnings

Project Member Reported by agrieve@chromium.org, Jun 21 2016

Issue description

They appear when building:
//chrome/android:chrome_java

E.g.:
../../../../../../tmp/tmpd3ZOHh/r5/values-v21/restriction_values.xml:295 "`VariationsRestrictParameterTitle`" is not translated in "am" (Amharic), "ar" (Arabic), "bg" (Bulgarian), "ca" (Catalan), "cs" (Czech), "da" (Danish), "de" (German), "el" (Greek), "es" (Spanish), "es-US" (Spanish: United States), "fa" (Persian), "fi" (Finnish), "fr" (French), "hi" (Hindi), "hr" (Croatian), "hu" (Hungarian), "in" (Indonesian), "it" (Italian), "iw" (Hebrew), "ja" (Japanese), "ko" (Korean), "lt" (Lithuanian), "lv" (Latvian), "nb" (Norwegian Bokmål), "nl" (Dutch), "pl" (Polish), "pt-BR" (Portuguese: Brazil), "pt-PT" (Portuguese: Portugal), "ro" (Romanian), "ru" (Russian), "sk" (Slovak), "sl" (Slovenian), "sr" (Serbian), "sv" (Swedish), "sw" (Swahili), "th" (Thai), "tl" (Tagalog), "tr" (Turkish), "uk" (Ukrainian), "vi" (Vietnamese), "zh" (Chinese), "zh-CN" (Chinese: China): MissingTranslation [warning]
  <string name="VariationsRestrictParameterTitle">Set the restriction on the fetching of the Variations seed</string>
 

Looks like this is intentional:
https://codereview.chromium.org/1062213002

So we just need to suppress these.
 
Status: Started (was: Available)
Fix is here: https://codereview.chromium.org/2102183003/#
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7e9b95f80ab96881ca7ecb5f6621536aad2743a

commit d7e9b95f80ab96881ca7ecb5f6621536aad2743a
Author: agrieve <agrieve@chromium.org>
Date: Fri Jul 01 03:40:39 2016

Suppress lint warnings for policy resources

They are unused because they are used by magic.
They are missing translations to save file size
(see  http://crbug.com/450548 )

BUG= 621771 

Review-Url: https://codereview.chromium.org/2102183003
Cr-Commit-Position: refs/heads/master@{#403401}

[modify] https://crrev.com/d7e9b95f80ab96881ca7ecb5f6621536aad2743a/build/android/lint/suppressions.xml

Status: Fixed (was: Started)

Sign in to add a comment