Incorrect UnusedResource warnings for values referenced by AndroidManifest.xml |
|||
Issue descriptionExample from //chrome/android:chrome_java__lint: ../../../../../../tmp/tmpd3ZOHh/r3/values/android_chrome_strings.xml:700 The resource `R.string.webapp_activity_title` appears to be unused: UnusedResources [warning] <string name="webapp_activity_title">"Web App"</string> It's used here: https://cs.chromium.org/chromium/src/chrome/android/java/AndroidManifest.xml
,
Jul 1 2016
Fix is here: https://codereview.chromium.org/2113233002 Confirmed it addresses the examples listed above.
,
Jul 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3528705e8b93d3a070f1d31e2dd355db1c33f52c commit 3528705e8b93d3a070f1d31e2dd355db1c33f52c Author: agrieve <agrieve@chromium.org> Date: Tue Jul 05 19:48:20 2016 Provide AndroidManifest.xml to chrome_java to fix UnusedResources warnings BUG= 621770 Review-Url: https://codereview.chromium.org/2113233002 Cr-Commit-Position: refs/heads/master@{#403818} [modify] https://crrev.com/3528705e8b93d3a070f1d31e2dd355db1c33f52c/build/android/lint/suppressions.xml [modify] https://crrev.com/3528705e8b93d3a070f1d31e2dd355db1c33f52c/chrome/android/BUILD.gn [modify] https://crrev.com/3528705e8b93d3a070f1d31e2dd355db1c33f52c/content/shell/android/BUILD.gn
,
Jul 26 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by twelling...@chromium.org
, Jun 25 2016There are other incorrect uses in clank_java__lint e.g.: <issue id="UnusedResources" severity="Error" message="The resource `R.xml.about_chrome_preferences` appears to be unused" category="Performance" priority="3" summary="Unused resources" explanation="Unused resources make applications larger and slow down builds."> <location file="chrome/android/java/res/xml/about_chrome_preferences.xml"/> </issue> <issue id="UnusedResources" severity="Error" message="The resource `R.xml.accessibility_preferences` appears to be unused" category="Performance" priority="3" summary="Unused resources" explanation="Unused resources make applications larger and slow down builds."> <location file="chrome/android/java/res/xml/accessibility_preferences.xml"/> </issue> <issue id="UnusedResources" severity="Error" message="The resource `R.layout.accessibility_tab_switcher` appears to be unused" category="Performance" priority="3" summary="Unused resources" explanation="Unused resources make applications larger and slow down builds."> <location file="chrome/android/java/res/layout/accessibility_tab_switcher.xml"/> </issue>