New issue
Advanced search Search tips

Issue 621770 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 607761



Sign in to add a comment

Incorrect UnusedResource warnings for values referenced by AndroidManifest.xml

Project Member Reported by agrieve@chromium.org, Jun 21 2016

Issue description

Example from //chrome/android:chrome_java__lint:

../../../../../../tmp/tmpd3ZOHh/r3/values/android_chrome_strings.xml:700 The resource `R.string.webapp_activity_title` appears to be unused: UnusedResources [warning]
<string name="webapp_activity_title">"Web App"</string>

It's used here:
https://cs.chromium.org/chromium/src/chrome/android/java/AndroidManifest.xml
 
There are other incorrect uses in clank_java__lint e.g.:

   <issue
        id="UnusedResources"
        severity="Error"
        message="The resource `R.xml.about_chrome_preferences` appears to be unused"
        category="Performance"
        priority="3"
        summary="Unused resources"
        explanation="Unused resources make applications larger and slow down builds.">
        <location
            file="chrome/android/java/res/xml/about_chrome_preferences.xml"/>
    </issue>

    <issue
        id="UnusedResources"
        severity="Error"
        message="The resource `R.xml.accessibility_preferences` appears to be unused"
        category="Performance"
        priority="3"
        summary="Unused resources"
        explanation="Unused resources make applications larger and slow down builds.">
        <location
            file="chrome/android/java/res/xml/accessibility_preferences.xml"/>
    </issue>

    <issue
        id="UnusedResources"
        severity="Error"
        message="The resource `R.layout.accessibility_tab_switcher` appears to be unused"
        category="Performance"
        priority="3"
        summary="Unused resources"
        explanation="Unused resources make applications larger and slow down builds.">
        <location
            file="chrome/android/java/res/layout/accessibility_tab_switcher.xml"/>
    </issue>
Status: Started (was: Assigned)
Fix is here: https://codereview.chromium.org/2113233002

Confirmed it addresses the examples listed above.
Status: Fixed (was: Started)

Sign in to add a comment