New issue
Advanced search Search tips

Issue 621769 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 607761



Sign in to add a comment

Android lint warnings do not show proper path to erroneous files

Project Member Reported by agrieve@chromium.org, Jun 21 2016

Issue description

E.g.:
../../../../../../tmp/tmpd3ZOHh/s0/ChromeBackupAgent.java:191 Consider using `apply()` instead; `commit` writes its data to persistent storage immediately, whereas `apply` will handle it in the background: CommitPrefEdits [warning]
        sharedPrefs.edit().clear().commit();

Should be:
chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java


E.g.:
../../../../../../tmp/tmpd3ZOHh/r3/values-vi/android_chrome_strings.xml:561 For language "vi" (Vietnamese) the following quantities are not relevant: `one`: UnusedQuantity 

Should be:
gen/chrome/android/chrome_strings_grd.resources.zip

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f9e0b4e45f6ae6a8822fa46f87b80c36f8c6339

commit 3f9e0b4e45f6ae6a8822fa46f87b80c36f8c6339
Author: agrieve <agrieve@chromium.org>
Date: Wed Jun 29 14:32:37 2016

Make android lint warnings show closer-to-correct file paths

Many of the paths are within /tmp. To address those, this change adds
relevant parent directories or path to originating .zip file in order
to provide context.

BUG= 621769 

Review-Url: https://codereview.chromium.org/2102373002
Cr-Commit-Position: refs/heads/master@{#402802}

[modify] https://crrev.com/3f9e0b4e45f6ae6a8822fa46f87b80c36f8c6339/build/android/gyp/lint.py

Status: Fixed (was: Assigned)

Sign in to add a comment