New issue
Advanced search Search tips

Issue 621767 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Cancelling "Payment processing" dialog crashes the renderer

Project Member Reported by rouslan@chromium.org, Jun 21 2016

Issue description

If the user taps the Android "back" button while "Payment processing" dialog is up, then website's complete() promise will crash the renderer. This is because the renderer will attempt to use the now closed mojo pipe to the browser.
 
http://crrev.com/2083883003 has the fix
Issue 621794 has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3897d84540af80d6f88cc5ecc0b89d722ab366ae

commit 3897d84540af80d6f88cc5ecc0b89d722ab366ae
Author: rouslan <rouslan@chromium.org>
Date: Tue Jun 21 21:18:07 2016

Reject PaymentResponse.complete() promise on error.

If the user cancels the PaymentRequest UI by clicking on the Android
"back" button while the website is processing the transaction, then
website's complete() call should be rejected.

BUG= 621767 

Review-Url: https://codereview.chromium.org/2083883003
Cr-Commit-Position: refs/heads/master@{#401110}

[modify] https://crrev.com/3897d84540af80d6f88cc5ecc0b89d722ab366ae/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/3897d84540af80d6f88cc5ecc0b89d722ab366ae/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

Status: Fixed (was: Started)
Not see this crash in latest Dev build - 53.0.2780.0 build

Sign in to add a comment