New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621746 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 584077
issue 620511



Sign in to add a comment

Teach bugdroid to not send emails on certain commits

Project Member Reported by martiniss@chromium.org, Jun 21 2016

Issue description

Probably through some special git footer.

Context is we don't want commits from the recipe roller to send emails to users, but we do want them to show up on the bug.

We should also probably make the actual comment smaller; I don't think we need the full comment text. 
 
sheyang, how could I modify bugdroid to accept something like this? 
You probably need to start from log_parser to recognize the new keyword (example https://codereview.chromium.org/2030003003/diff/20001/infra/services/bugdroid/log_parser.py), and pass it down to IssueTrackerManager to set send_email to False.
Blocking: 584077

Comment 4 by jam@chromium.org, Jun 29 2016

Blocking: 620511
WIP CL at https://chromium-review.googlesource.com/c/356694/

Didn't end up getting much done with this. I believe the correct reviewer now is agable@ or mmoss@, since sheyang left Google.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ba095768d776568605a29ddad503deb2ce1e184e

commit ba095768d776568605a29ddad503deb2ce1e184e
Author: Stephen Martinis <martiniss@chromium.org>
Date: Fri Aug 19 23:53:41 2016

Fix bugdroid sending email flag

Forgot to add (?m) to the beginning of the regex, which changes it to run in
"multiline" mode; see https://docs.python.org/2/library/re.html#contents-of-module-re
for more details.

BUG= 621746 

Change-Id: I78db8e0c3c52613f15b689787f59104ce7e680b0
Reviewed-on: https://chromium-review.googlesource.com/368232
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/ba095768d776568605a29ddad503deb2ce1e184e/infra/services/bugdroid/log_parser.py
[modify] https://crrev.com/ba095768d776568605a29ddad503deb2ce1e184e/infra/services/bugdroid/test/log_parser_test.py

Labels: Pri-2
If this is really a Pri-1, find an owner and update the priority.

This is the result of a bulk edit that moved high priority available bugs to a lower priority in an attempt to be more honest with bug filers.
Status: Fixed (was: Available)
I fixed this.

Sign in to add a comment