New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621745 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 626497



Sign in to add a comment

metrics: monitor devserver uplink health in monarch

Project Member Reported by akes...@chromium.org, Jun 21 2016

Issue description

We suspect we are saturating devserver uplink, intermittently. We don't learn the whole story just by looking at existing metrics on network utilization.

We could add a watchdog timer that tries every 5 minutes to upload a 1MB file somewhere, and sends a metric about how long this takes. This will be a more accurate reflection of the sort of health we're trying to measure.


 

Comment 1 by autumn@chromium.org, Jun 21 2016

Labels: -current-issue
Labels: Hotlist-CrOS-DevServerLoad
Labels: -dut-health
Cc: dgarr...@chromium.org jrbarnette@chromium.org
Labels: -Hotlist-CrOS-DevServerLoad Hotlist-CrOS-DutHealth
Summary: metrics: monitor devserver uplink health in monarch (was: monitor devserver uplink health in monarch)
Note -- the current plan of attack is to report the static content served, broken down by artifact type.
Issue 622145 has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/ef4e070e5590f1135192e1b18d23b345ba219393

commit ef4e070e5590f1135192e1b18d23b345ba219393
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Jun 28 00:01:42 2016

[devserver] Added an apache_log_metrics.py script

This script uploads metrics to Monarch based on apache's request log.

BUG= chromium:621745 
TEST=None

Change-Id: I47bf61913da25d44e3fe23fc9502e9c9caebf8a4
Reviewed-on: https://chromium-review.googlesource.com/356299
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/ef4e070e5590f1135192e1b18d23b345ba219393/devserver.py
[add] https://crrev.com/ef4e070e5590f1135192e1b18d23b345ba219393/apache_log_metrics_unittest.py
[add] https://crrev.com/ef4e070e5590f1135192e1b18d23b345ba219393/apache_log_metrics.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/be84dd129fb5d6ec438278e74381eba5c002162d

commit be84dd129fb5d6ec438278e74381eba5c002162d
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Jul 01 18:54:37 2016

Add a tail_until_writer_finished script.

This is useful for tailing Apache logs in a rigorous way. We don't want
to use 'tail -f' because it never terminates, even if the writer closes
the file. However, we can't just repeatedly reopen and read the file
without risking losing messages during log rotation. This script uses
inotify to detect when a writer to the tailed file closes the file.

BUG= chromium:621745 
TEST=unit tests

Change-Id: I5b060b38e8c3ec316ff6f467b317f895cbf5c394
Reviewed-on: https://chromium-review.googlesource.com/357953
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Dan Shi <dshi@google.com>

[add] https://crrev.com/be84dd129fb5d6ec438278e74381eba5c002162d/tail_until_writer_finished.py
[add] https://crrev.com/be84dd129fb5d6ec438278e74381eba5c002162d/tail_until_writer_finished_unittest.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/1417852edb2a5709ce48bd37b39ec23b10acf261

commit 1417852edb2a5709ce48bd37b39ec23b10acf261
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Jun 28 00:13:09 2016

Blockedon: 626497
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/9b25e01b5d4d6ac4a075d242227f73cf48c25d87

commit 9b25e01b5d4d6ac4a075d242227f73cf48c25d87
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Jul 08 18:50:48 2016

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/ee5a8c3e7156974b924c8bd5f3e0786ea3896749

commit ee5a8c3e7156974b924c8bd5f3e0786ea3896749
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Jul 08 21:45:18 2016

tail_until_writer_finished: Refactor as cxtmanager

Per akeshet@'s comments in CL:359000, refactored
tail_until_writer_finished to use a contextmanager for the inotifywait
process.

BUG= chromium:621745 
TEST=unittests still pass.

Change-Id: Ic786b3b1fbfc98d74a40fbb548745c987b8a558e
Reviewed-on: https://chromium-review.googlesource.com/359319
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/ee5a8c3e7156974b924c8bd5f3e0786ea3896749/tail_until_writer_finished.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/5828e5e61091547b474ab1357e734c743e7ab710

commit 5828e5e61091547b474ab1357e734c743e7ab710
Author: Paul Hobbs <phobbs@google.com>
Date: Mon Jul 11 19:10:08 2016

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/90d759750b0573dfd08fdea298939c2859247459

commit 90d759750b0573dfd08fdea298939c2859247459
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Jul 12 00:31:22 2016

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/5d6cdafb486db67f2d342a63de9b9cb821b855e8

commit 5d6cdafb486db67f2d342a63de9b9cb821b855e8
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Jul 12 21:37:57 2016

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/a166a1629b471c02de02dceec5ff115b4bd1a628

commit a166a1629b471c02de02dceec5ff115b4bd1a628
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Jul 13 00:03:22 2016

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/338baee8d01efce080fd752c310c8e3700924798

commit 338baee8d01efce080fd752c310c8e3700924798
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Jul 13 20:42:34 2016

apache_log_metrics: Use stdin.readline

sys.stdin does not begin reading lines until a large stdin buffer has
been filled or the stdin filehandle has been closed. This affects the
latency of the apache_log_metrics script - instead, we want it to begin
emitting metrics as soon as an input line is available.

Furthermore, tail_until_writer_finished buffers its output to
sys.stdout, which causes the same latency problem. Solve this by passing
"-u" flag to python, forcing unbuffered output (and input).

TEST=ran script locally, unittests pass.
BUG= chromium:621745 

Change-Id: Ie882d5c3a6d939145287c306e3833672a7abc572
Reviewed-on: https://chromium-review.googlesource.com/360332
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/338baee8d01efce080fd752c310c8e3700924798/tail_until_writer_finished.py
[modify] https://crrev.com/338baee8d01efce080fd752c310c8e3700924798/apache_log_metrics.py

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/338baee8d01efce080fd752c310c8e3700924798

commit 338baee8d01efce080fd752c310c8e3700924798
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Jul 13 20:42:34 2016

apache_log_metrics: Use stdin.readline

sys.stdin does not begin reading lines until a large stdin buffer has
been filled or the stdin filehandle has been closed. This affects the
latency of the apache_log_metrics script - instead, we want it to begin
emitting metrics as soon as an input line is available.

Furthermore, tail_until_writer_finished buffers its output to
sys.stdout, which causes the same latency problem. Solve this by passing
"-u" flag to python, forcing unbuffered output (and input).

TEST=ran script locally, unittests pass.
BUG= chromium:621745 

Change-Id: Ie882d5c3a6d939145287c306e3833672a7abc572
Reviewed-on: https://chromium-review.googlesource.com/360332
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/338baee8d01efce080fd752c310c8e3700924798/tail_until_writer_finished.py
[modify] https://crrev.com/338baee8d01efce080fd752c310c8e3700924798/apache_log_metrics.py

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/ecea32aa73dfb6bdf7a593f15a9f17da3cf8c1d8

commit ecea32aa73dfb6bdf7a593f15a9f17da3cf8c1d8
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Jul 14 18:25:57 2016

Status: Fixed (was: Assigned)
Labels: VerifyIn-54
Labels: VerifyIn-55

Comment 22 by dchan@chromium.org, Oct 10 2016

Labels: -VerifyIn-55

Comment 23 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 24 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 25 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 26 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 27 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 29 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment