New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621740 link

Starred by 5 users

Issue metadata

Status: Duplicate
Merged: issue 621004
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Omnibox dropdown and textfield colors should always be white with custom themes

Project Member Reported by shrike@chromium.org, Jun 21 2016

Issue description

Version: 53.0.2773.0
OS: 10.11

Currently with a custom theme, the Omnibox textfield background color is always white, and the Omnibox dropdown color is white or black depending on the lightness/darkness of the custom theme. Instead (per sgabriel@), the Omnibox textfield and dropdown colors should always match, and they should be white in normal mode and black in Incognito mode, regardless of the custom theme's colors. This is to reinforce that the user is or is not in Incognito mode.

 

Comment 1 by shrike@chromium.org, Jun 21 2016

Components: UI>Browser>Omnibox
Labels: Proj-MaterialDesign-NativeUI

Comment 2 Deleted

Comment 3 by shrike@chromium.org, Jun 22 2016

Labels: -ReleaseBlock-Stable
Summary: Omnibox dropdown and textfield colors should always be white with custom themes (was: Omnibox dropdown and textfield colors should follow Incognito mode, even with custom themes)
The new plan: do what views does today, where we always use the normal omnibox/dropdown for themes, and only use the dark ones in non-themed incognito mode.  This is not less clear about what's incognito than the pre-MD world, and minimizes theme color compat risks.

Project Member

Comment 4 by sheriffbot@chromium.org, Jun 23 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by shrike@chromium.org, Jun 23 2016

Mergedinto: 621004
Status: Duplicate (was: Assigned)

Sign in to add a comment