New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621736 link

Starred by 2 users
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Jul 2016
Cc:
dbeam@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

PDF: Polymer maintenance tasks

Project Member Reported by tsergeant@chromium.org, Jun 21 2016 
Polymer moves quickly, and MD PDF hasn't seen a lot of attention over the last few months. In particular:

* Console warning: "This file [iron-flex-layout-extracted.js] is deprecated. Please use `iron-flex-layout/iron-flex-layout-classes.html`, and one of the specific dom-modules instead"

* Switch to consistently use chrome://resources/html/polymer.html to avoid "Polymer is already defined" console error.

* i18n_template is deprecated (and it uses the deprecated `deep` selector), so we should use a different i18n system.

Comment 1 by thestig@chromium.org, Jun 21 2016

Cc: dbeam@chromium.org
+dbeam FYI. Not sure if we need more help here or reviewers.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0402963c3f9452446b89d3d7807bcf749a519777

commit 0402963c3f9452446b89d3d7807bcf749a519777
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Jun 22 02:05:06 2016

PDF: Small cleanup of Polymer usage

* Replace direct imports of polymer.html with
  chrome://resources/html/polymer.html. This means the manual import of
  polymer_config.js is no longer necessary.
* Avoid importing deprecated iron-flex-layout files by changing
  paper-styles import.

BUG= 621736 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2084813002
Cr-Commit-Position: refs/heads/master@{#401161}

[modify] https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html
[modify] https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777/chrome/browser/resources/pdf/elements/viewer-bookmarks-content/viewer-bookmarks-content.html
[modify] https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html
[modify] https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777/chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.html
[modify] https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
[modify] https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
[modify] https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777/chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html
[modify] https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.html
[modify] https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.html
[modify] https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.html
[modify] https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777/chrome/browser/resources/pdf/index.html
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/930c85305671e9a24a3ac4eb9ea1de0cd447f961

commit 930c85305671e9a24a3ac4eb9ea1de0cd447f961
Author: tsergeant <tsergeant@chromium.org>
Date: Mon Jun 27 04:57:46 2016

PDF: Fix layout issues caused by removing iron-flex-layout

In crrev.com/401161, the deprecated version of iron-flex-layout was removed
from the PDF viewer. This version added styles to the page which were seen
by every element, regardless of whether they expected it. Thus, removing
it from the page had some unexpected side effects:

* The bookmarks menu in the toolbar would always show, due to a change
  in how [hidden] was defined.
* The password field was laid out incorrectly due to not importing the
  new version of iron-flex-layout correctly.

This CL fixes both of these regressions.

BUG= 622582 , 621736 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2092023002
Cr-Commit-Position: refs/heads/master@{#402112}

[modify] https://crrev.com/930c85305671e9a24a3ac4eb9ea1de0cd447f961/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
[modify] https://crrev.com/930c85305671e9a24a3ac4eb9ea1de0cd447f961/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.css
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6780c776212ce304bb05dbf60b9ced28a89fb7c8

commit 6780c776212ce304bb05dbf60b9ced28a89fb7c8
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Jul 12 07:47:24 2016

PDF: Replace usage of i18nTemplate with Polymer data binding

i18n_template.js is deprecated, and is built on top of a deprecated
platform feature. The replacement for it (ReplaceTemplateExpresssions)
is not available for component extensions. This CL replaces all usage of
i18nTemplate in the PDF viewer with Polymer data binding,
which works sufficiently well since there's no complicated l10n in the
PDF viewer.

BUG= 621736 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2123983003
Cr-Commit-Position: refs/heads/master@{#404796}

[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html
[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.js
[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.js
[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html
[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.js
[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.html
[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/index.html
[modify] https://crrev.com/6780c776212ce304bb05dbf60b9ced28a89fb7c8/chrome/browser/resources/pdf/pdf.js

Comment 5 by tsergeant@chromium.org, Jul 15 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment