luci-go: fix the example for flagenum |
||||||||
Issue descriptionhttps://cs.chromium.org/chromium/infra/go/src/github.com/luci/luci-go/common/flag/flagenum/example_flagenum_test.go?q=flagenum+file:%5Einfra/go/src/github%5C.com/luci/luci-go/&sq=package:chromium&l=28 This should be FlagString(*val), otherwise it will always return an empty string, because the type and its pointer are not equal.
,
Aug 24 2016
,
Oct 3 2016
Not really working on it, making available.
,
Oct 4 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 25 2017
,
Oct 26
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/602c9611ca08979086010bdd119c256279039ad5 commit 602c9611ca08979086010bdd119c256279039ad5 Author: Nodir Turakulov <nodir@google.com> Date: Mon Oct 29 17:59:35 2018 Fix flagenum example R=sergeyberezin@chromium.org Bug: 621735 Change-Id: Ia45fc64559368fd0981986cf89d9fa889e30429d Reviewed-on: https://chromium-review.googlesource.com/c/1302829 Auto-Submit: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> [modify] https://crrev.com/602c9611ca08979086010bdd119c256279039ad5/common/flag/flagenum/example_flagenum_test.go
,
Oct 29
take away: making a one-symbol change in code is preferred to filing a bug about it, especially when you already figured the bug out |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by benhenry@chromium.org
, Aug 3 2016