New issue
Advanced search Search tips

Issue 621734 link

Starred by 2 users
Status: Fixed
Owner:
karandeepb@chromium.org
Closed: Jun 2016
Cc:
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 500806



Sign in to add a comment

MacViews on 10.9: Failures in TextInput_{Delete,MoveEditing}Commands

Project Member Reported by tapted@chromium.org, Jun 21 2016 
Chrome Version       : 53.0.2767.4
OS Version: OS X 10.9

See https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/129603

They don't happen in the 10.10 run: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10.10_rel_ng/builds/101009

BridgedNativeWidgetTest.TextInput_DeleteCommands

failures like

BridgedNativeWidgetTest.TextInput_DeleteCommands (run #1):
[ RUN      ] BridgedNativeWidgetTest.TextInput_DeleteCommands
../../ui/views/cocoa/bridged_native_widget_unittest.mm:534: Failure
Value of: GetActualSelectionRange().length
  Actual: 1
Expected: GetExpectedSelectionRange().length
Which is: 4
Google Test trace:
../../ui/views/cocoa/bridged_native_widget_unittest.mm:528: Testing range [0-1] for case ab c and selector deleteForward:

../../ui/views/cocoa/bridged_native_widget_unittest.mm:537: Failure
Value of: GetActualText()
  Actual: b c
Expected: GetExpectedText()
Which is: (null)
Google Test trace:
../../ui/views/cocoa/bridged_native_widget_unittest.mm:528: Testing range [0-1] for case ab c and selector deleteForward:

../../ui/views/cocoa/bridged_native_widget_unittest.mm:534: Failure
Value of: GetActualSelectionRange().length
  Actual: 2
Expected: GetExpectedSelectionRange().length
Which is: 4
Google Test trace:
../../ui/views/cocoa/bridged_native_widget_unittest.mm:528: Testing range [0-2] for case ab c and selector deleteForward:
/* etc */


BridgedNativeWidgetTest.TextInput_MoveEditingCommands

failures like

BridgedNativeWidgetTest.TextInput_MoveEditingCommands (run #1):
[ RUN      ] BridgedNativeWidgetTest.TextInput_MoveEditingCommands
../../ui/views/cocoa/bridged_native_widget_unittest.mm:539: Failure
Value of: GetActualSelectionRange().location
  Actual: 1
Expected: GetExpectedSelectionRange().location
Which is: 4
Google Test trace:
../../ui/views/cocoa/bridged_native_widget_unittest.mm:528: Testing range [0-0] for case ab c and selector moveForward:

../../ui/views/cocoa/bridged_native_widget_unittest.mm:534: Failure
Value of: GetActualSelectionRange().length
  Actual: 1
Expected: GetExpectedSelectionRange().length
Which is: 4
Google Test trace:
../../ui/views/cocoa/bridged_native_widget_unittest.mm:528: Testing range [0-1] for case ab c and selector moveForward:

../../ui/views/cocoa/bridged_native_widget_unittest.mm:539: Failure
Value of: GetActualSelectionRange().location
  Actual: 1
Expected: GetExpectedSelectionRange().location
Which is: 4
Google Test trace:
../../ui/views/cocoa/bridged_native_widget_unittest.mm:528: Testing range [0-1] for case ab c and selector moveForward:

../../ui/views/cocoa/bridged_native_widget_unittest.mm:534: Failure
Value of: GetActualSelectionRange().length
  Actual: 2
Expected: GetExpectedSelectionRange().length
Which is: 4
Google Test trace:
../../ui/views/cocoa/bridged_native_widget_unittest.mm:528: Testing range [0-2] for case ab c and selector moveForward:

/* etc */
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce26dc83bff3f79f27b698f9cddeb7d9470949a

commit 1ce26dc83bff3f79f27b698f9cddeb7d9470949a
Author: tapted <tapted@chromium.org>
Date: Mon Jun 27 03:13:03 2016

Add views_unittests to Mac10.{9,9(dbg),10,11} and asan bots

Disable a few tests we haven't gotten to fixing yet, since it's more
important to get the rest into continuous integration at this point.

Will land this at a quiet time on the weekend, and monitor closely
for potential flakes or other problems.

Recently added tests disabled due to missing GetGlobalCapture()
implementation:
 - MenuRunnerTest.WidgetDoesntTakeCapture
 - WidgetTest.MousePressCausesCapture
 - WidgetTest.CaptureDuringMousePressNotOverridden

Disabled on 10.9 only (different native Textfield behaviour):
 - BridgedNativeWidgetTest.TextInput_MoveEditingCommands
 - BridgedNativeWidgetTest.TextInput_DeleteCommands

Also disables:
 - WidgetTest.FullscreenFrameLayout [fails only on bots]
 - StyledLabelTest.StyledRangeBold [fails only on 10.10]

But the other ~720 tests pass.

Disables tests for recent regressions in r401862 and r401987. We need
that continuous integration - stat!

BUG= 500806 ,  621734 ,  622979 ,  622983 ,  622979 ,  607403 ,  623420 ,  623421 

Review-Url: https://codereview.chromium.org/1925943002
Cr-Commit-Position: refs/heads/master@{#402103}

[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/cocoa/bridged_native_widget_unittest.mm
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/styled_label_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/textfield/textfield_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/widget/widget_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1373d81bf918bd38991cb3bd790834fe53189632

commit 1373d81bf918bd38991cb3bd790834fe53189632
Author: karandeepb <karandeepb@chromium.org>
Date: Tue Jun 28 03:43:08 2016

MacViews: Fix BridgedNativeWidget.* tests which fail on OSX 10.9.

This CL fixes the following views_unittests which fail on OSX 10.9-
  -BridgedNativeWidgetTest.TextInput_DeleteCommands
  -BridgedNativeWidgetTest.TextInput_MoveEditingCommands

The reason for these failures is that an NSTextView on 10.9 behaves weirdly if
initialized with an NSZeroRect as its frame rectangle. Changing the frame
rectangle to a larger one fixes the tests.

BUG= 621734 ,  607403 

Review-Url: https://codereview.chromium.org/2093003002
Cr-Commit-Position: refs/heads/master@{#402394}

[modify] https://crrev.com/1373d81bf918bd38991cb3bd790834fe53189632/ui/views/cocoa/bridged_native_widget_unittest.mm

Comment 3 by karandeepb@chromium.org, Jun 28 2016

Status: Fixed (was: Assigned)

Comment 4 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled
►

Sign in to add a comment