Issue metadata
Sign in to add a comment
|
MD Settings: iron-dropdown irregularities |
||||||||||||||||||||||||
Issue descriptionchrome://md-settings/managePasswords the <iron-dropdown> opened by tapping a 3-dot menu for a page in "On startup -> Open a specific page": * does not animate in or out * does not respond to arrow keys the <cr-shared-menu> opened by tapping a 3-dot menu in on one of the password entries in "Manage passwords": * does not animate in or out * opens with a weird gray focus ring * is not keyboard accessible at all, except for double-tapping Escape to close * does not close on clicking outside of the section (eg the side of the page)
,
Jun 21 2016
,
Jun 24 2016
,
Jul 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53b690eb87b6c8786574622243893049d3745bde commit 53b690eb87b6c8786574622243893049d3745bde Author: stevenjb <stevenjb@chromium.org> Date: Tue Jul 12 00:46:40 2016 Unify iron-dropdown CSS Moves shared CSS for iron-dropdown to settings_shared_css.html. Also makes dropdown items actionable. BUG= 621731 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2133793003 Cr-Commit-Position: refs/heads/master@{#404756} [modify] https://crrev.com/53b690eb87b6c8786574622243893049d3745bde/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html [modify] https://crrev.com/53b690eb87b6c8786574622243893049d3745bde/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/53b690eb87b6c8786574622243893049d3745bde/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html [modify] https://crrev.com/53b690eb87b6c8786574622243893049d3745bde/chrome/browser/resources/settings/settings_shared_css.html
,
Jul 12 2016
Also: * The menu is not placed correctly when near the bottom edge of the screen, instead a scrollbar is shown. * The scrollbar overlaps the margin making the content look cramped.
,
Jul 12 2016
Note: this is the pattern we use in md-settings for iron-dropdown:
<iron-dropdown opened="{{menuOpened}}">
<div class="dropdown-content">
<paper-item id="item1" on-tap="onTap_">Item1</paper-item>
<paper-item id="item2" on-tap="onTap_">Item2</paper-item>
</div>
</iron-dropdown>
We would prefer to replace <paper-item> with <div> to reduce overhead on page load.
,
Jul 12 2016
,
Jul 12 2016
Note: for issues with paper-dropdown-item, see issue 624303
,
Oct 6 2016
,
Oct 13 2016
All reported issues are addressed as part of https://bugs.chromium.org/p/chromium/issues/detail?id=639718, except for the in/out animation.
,
Oct 21 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mahmadi@chromium.org
, Jun 21 2016