New issue
Advanced search Search tips

Issue 621723 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 614382



Sign in to add a comment

Languages "Learn more" help link needs to be changed

Project Member Reported by michae...@chromium.org, Jun 20 2016

Issue description

In chrome://settings/languages the "Learn more" link points to:
https://support.google.com/chrome/topic/1678461

which just redirects to the Chrome help center with "Settings and display" open.

Perhaps this is a more relevant topic: https://support.google.com/chrome/answer/173424?hl=en&ref_topic=3434353

although it doesn't actually address what's discussed in the Settings page ("Add languages and drag to order them based on your preference").

On Chrome OS, the link is correct: https://support.google.com/chromebook/answer/1059490

And that Chrome OS page has a useful section on "Webpage language" that should probably be in the aforementioned topic for desktop Chrome.
 
Labels: Hotlist-Settings-Languages
Status: Available (was: Untriaged)
Summary: Languages "Learn more" help link needs to be changed (was: Languages "Learn more" help link is broken)
Can Repro. Change https://support.google.com/chrome/topic/1678461 to https://support.google.com/chromebook/answer/1059490
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 10 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by dpa...@chromium.org, May 10 2018

Owner: dpa...@chromium.org
Status: Started (was: Untriaged)
There is no "Learn more" link in Languages anymore. Uploaded a CL to remove the unused constant at https://chromium-review.googlesource.com/c/chromium/src/+/1053155.
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b26ed858c235aaab7dff139a3bbf163606efe93f

commit b26ed858c235aaab7dff139a3bbf163606efe93f
Author: dpapad <dpapad@chromium.org>
Date: Thu May 10 23:56:53 2018

Cleanup: Remove unused constant kLanguageSettingsLearnMoreUrl for non-CrOS.

Also doing the same for kEasyUnlockLearnMoreUrl, which is only used in CrOS.

Bug:  621723 
Change-Id: Ieada2f363c886e9321016de45a2157a3d35ac1fb
Reviewed-on: https://chromium-review.googlesource.com/1053155
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557728}
[modify] https://crrev.com/b26ed858c235aaab7dff139a3bbf163606efe93f/chrome/common/url_constants.cc
[modify] https://crrev.com/b26ed858c235aaab7dff139a3bbf163606efe93f/chrome/common/url_constants.h

Comment 5 by dpa...@chromium.org, May 10 2018

Status: Fixed (was: Started)

Sign in to add a comment