New issue
Advanced search Search tips

Issue 621720 link

Starred by 6 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----

Blocking:
issue 617822



Sign in to add a comment

Improve support for unlinkified URLs

Project Member Reported by tedc...@chromium.org, Jun 20 2016

Issue description

On desktop Chrome if you select text, you will get two possible options if you right click.

1.) If the text looks to be a search term, you'll get Search <Engine> for "blah"
2.) If the text looks like a URL, you'll get "Go to blah.com".

On Android, we only present you with the option to search, but we should really handle URLs better.

For Desktop's implementation see RenderViewContextMenu::AppendSearchProvider

https://cs.chromium.org/chromium/src/chrome/browser/renderer_context_menu/render_view_context_menu.cc?l=1224
 
Cc: tedc...@chromium.org
Owner: wychen@chromium.org
Components: UI>Browser>Contextual
Cc: twelling...@chromium.org wychen@chromium.org
Owner: amaralp@chromium.org
Assigning to amaralp as they own all things action mode at this point.

Contextual search added logic to detect URLs on tap and long press, but this would be a nice little extra in cases where that is disabled.
Cc: ctzsm@chromium.org
I think Smart Select does something like this. ctzsm@, could you confirm.

It does provide something like this (will allow you to open in your default browser).  I don't know what happens if you're not currently in your default browser though (would smart select ask you to open it in a different app than you're currently in?).

This is definitely not as important as it once was, just a small, nice to have feature IMO (for example smart select and CS are disabled in incognito where this would not).  Definitely a low priority, but something to track.

Comment 6 by ctzsm@chromium.org, Jan 31 2018

Re c#5, yes it's possible that Smart Select will open a different app than you're currently in, it's TextClassifier's job to get all the apps that could accept certain types of an intent and choose one from them.

Smart Select won't work for links though.

Sign in to add a comment