New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621718 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Jun 2016
Cc:
tbuck...@chromium.org
█ dschuyler@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Should the sidebar have the waterfall effect also?

Project Member Reported by dpa...@chromium.org, Jun 20 2016 
As part of migrating to app-drawer (and away from paper-drawer-panel, paper-header-panel), I am removing the waterfall effect that exists in the sidebar, https://codereview.chromium.org/2074063003. (The waterfall effect in the main page is preserved).

From discussions with @dschuyler it seems that we are not 100% sure whether the sidebar should have waterfall effect. If so, it should be re-added back, which is possible by using the new app-header element with effects="waterfall".

Comment 1 by tbuck...@chromium.org, Jun 21 2016

Labels: Hotlist-MD-Settings-Structure
Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)
Sidebar does not need the waterfall effect, just the content area.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73fc005b160471c4ce9bdf14c4b97778e7166d09

commit 73fc005b160471c4ce9bdf14c4b97778e7166d09
Author: dpapad <dpapad@chromium.org>
Date: Wed Jun 22 00:25:16 2016

MD Settings: App drawer, remove TODO about waterfall effect.

BUG= 621718 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2082983003
Cr-Commit-Position: refs/heads/master@{#401145}

[modify] https://crrev.com/73fc005b160471c4ce9bdf14c4b97778e7166d09/chrome/browser/resources/settings/settings_ui/settings_ui.html

Comment 3 by dpa...@chromium.org, Jun 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment