Add vmstat to crosh |
|||||||||||||||
Issue descriptionI thought i filed a request, but apparently did not. vapier@, can you work on this?
,
Jun 20 2016
Yes.
,
Jun 21 2016
i'll review, but i'm not implementing. sorry :/.
,
Apr 14 2017
Issue 709682 has been merged into this issue.
,
Apr 14 2017
Justin, would you like to do this? It would be useful.
,
Apr 14 2017
,
Apr 15 2017
Yep, I'd be happy to take this one.
,
Apr 17 2017
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b0a9b6df810b26071335b3dab1640577cdbd1b3a commit b0a9b6df810b26071335b3dab1640577cdbd1b3a Author: Justin TerAvest <teravest@chromium.org> Date: Tue Apr 18 05:50:25 2017 crosh: Add vmstat command This is equivalent to running "vmstat 1". BUG= chromium:621711 TEST=Built/ran USB image, ran vmstat in crosh. Change-Id: I10b7ee0fb396f38bf7177f406295f9bfab0139a9 Reviewed-on: https://chromium-review.googlesource.com/479462 Commit-Ready: Justin TerAvest <teravest@chromium.org> Tested-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Luigi Semenzato <semenzato@chromium.org> [modify] https://crrev.com/b0a9b6df810b26071335b3dab1640577cdbd1b3a/crosh/crosh
,
Apr 18 2017
I checked in an initial version, but it sounds like dtor@ wants to add more flags, so I'm assigning this to him.
,
Apr 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/536619b70368ce8a49caeccb37e439ba2ef97a16 commit 536619b70368ce8a49caeccb37e439ba2ef97a16 Author: Dmitry Torokhov <dtor@chromium.org> Date: Sat Apr 22 04:57:48 2017 crosh: make vmstat command accept options To better aid in understanding memory access patterns on devices not in dev mode, let's make vmstat command accept various options. BUG=b:36197895, chromium:621711 TEST=Try invoking vmstat in crosh Change-Id: If0423bc0dd23d77da111b0bfa453edb0577ea3a5 Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/479133 Reviewed-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/536619b70368ce8a49caeccb37e439ba2ef97a16/crosh/crosh
,
Apr 25 2017
Seems likely we'd want this at least on M-59. Presumably too late for M-58?
,
Apr 25 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2017
Oops. I can't type.
,
Apr 26 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/9e0e741702e34792aab82084e99157a717f0cd4a commit 9e0e741702e34792aab82084e99157a717f0cd4a Author: Justin TerAvest <teravest@chromium.org> Date: Wed Apr 26 16:57:42 2017 crosh: Add vmstat command This is equivalent to running "vmstat 1". BUG= chromium:621711 TEST=Built/ran USB image, ran vmstat in crosh. Change-Id: I10b7ee0fb396f38bf7177f406295f9bfab0139a9 Reviewed-on: https://chromium-review.googlesource.com/479462 Commit-Ready: Justin TerAvest <teravest@chromium.org> Tested-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Luigi Semenzato <semenzato@chromium.org> (cherry picked from commit b0a9b6df810b26071335b3dab1640577cdbd1b3a) Reviewed-on: https://chromium-review.googlesource.com/487864 Reviewed-by: Justin TerAvest <teravest@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Tested-by: Dmitry Torokhov <dtor@chromium.org> [modify] https://crrev.com/9e0e741702e34792aab82084e99157a717f0cd4a/crosh/crosh
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/83834b409dc03434ee9e8067d26dc2b8054c6672 commit 83834b409dc03434ee9e8067d26dc2b8054c6672 Author: Dmitry Torokhov <dtor@chromium.org> Date: Wed Apr 26 17:15:02 2017 crosh: make vmstat command accept options To better aid in understanding memory access patterns on devices not in dev mode, let's make vmstat command accept various options. BUG=b:36197895, chromium:621711 TEST=Try invoking vmstat in crosh Change-Id: If0423bc0dd23d77da111b0bfa453edb0577ea3a5 Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/479133 Reviewed-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 536619b70368ce8a49caeccb37e439ba2ef97a16) Reviewed-on: https://chromium-review.googlesource.com/487865 Reviewed-by: Douglas Anderson <dianders@chromium.org> [modify] https://crrev.com/83834b409dc03434ee9e8067d26dc2b8054c6672/crosh/crosh
,
Apr 26 2017
,
Jan 22 2018
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by semenzato@chromium.org
, Jun 20 2016