New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621711 link

Starred by 5 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add vmstat to crosh

Project Member Reported by osh...@chromium.org, Jun 20 2016

Issue description

I thought i filed a request, but apparently did not. vapier@, can you work on this?
 
Cc: sonnyrao@chromium.org
For security we generally restrict usage of these commands.  Are you mostly interested in "vmstat 1"?

Comment 2 by osh...@chromium.org, Jun 20 2016

Labels: -Type-Bug Type-Feature
Yes.

Comment 3 by vapier@chromium.org, Jun 21 2016

Cc: vapier@chromium.org
Owner: ----
i'll review, but i'm not implementing.  sorry :/.

Comment 4 Deleted

Cc: diand...@chromium.org igo@chromium.org bccheng@chromium.org teravest@chromium.org dtor@chromium.org cylee@chromium.org
 Issue 709682  has been merged into this issue.
Owner: teravest@chromium.org
Justin, would you like to do this?  It would be useful.

Comment 7 by vapier@chromium.org, Apr 14 2017

Labels: -M-54 -MovedFrom-53 Hotlist-GoodFirstBug
Yep, I'd be happy to take this one.
Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b0a9b6df810b26071335b3dab1640577cdbd1b3a

commit b0a9b6df810b26071335b3dab1640577cdbd1b3a
Author: Justin TerAvest <teravest@chromium.org>
Date: Tue Apr 18 05:50:25 2017

crosh: Add vmstat command

This is equivalent to running "vmstat 1".

BUG= chromium:621711 
TEST=Built/ran USB image, ran vmstat in crosh.

Change-Id: I10b7ee0fb396f38bf7177f406295f9bfab0139a9
Reviewed-on: https://chromium-review.googlesource.com/479462
Commit-Ready: Justin TerAvest <teravest@chromium.org>
Tested-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/b0a9b6df810b26071335b3dab1640577cdbd1b3a/crosh/crosh

Owner: dtor@chromium.org
I checked in an initial version, but it sounds like dtor@ wants to add more flags, so I'm assigning this to him.
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/536619b70368ce8a49caeccb37e439ba2ef97a16

commit 536619b70368ce8a49caeccb37e439ba2ef97a16
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Sat Apr 22 04:57:48 2017

crosh: make vmstat command accept options

To better aid in understanding memory access patterns on devices not
in dev mode, let's make vmstat command accept various options.

BUG=b:36197895, chromium:621711 
TEST=Try invoking vmstat in crosh

Change-Id: If0423bc0dd23d77da111b0bfa453edb0577ea3a5
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/479133
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/536619b70368ce8a49caeccb37e439ba2ef97a16/crosh/crosh

Labels: Merge-Request-58 M-58
Seems likely we'd want this at least on M-59.  Presumably too late for M-58?
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 25 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-58 -Merge-Review-58 Merge-Request-59 M-59
Oops.  I can't type.
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 26 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 26 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9e0e741702e34792aab82084e99157a717f0cd4a

commit 9e0e741702e34792aab82084e99157a717f0cd4a
Author: Justin TerAvest <teravest@chromium.org>
Date: Wed Apr 26 16:57:42 2017

crosh: Add vmstat command

This is equivalent to running "vmstat 1".

BUG= chromium:621711 
TEST=Built/ran USB image, ran vmstat in crosh.

Change-Id: I10b7ee0fb396f38bf7177f406295f9bfab0139a9
Reviewed-on: https://chromium-review.googlesource.com/479462
Commit-Ready: Justin TerAvest <teravest@chromium.org>
Tested-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
(cherry picked from commit b0a9b6df810b26071335b3dab1640577cdbd1b3a)
Reviewed-on: https://chromium-review.googlesource.com/487864
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Commit-Queue: Dmitry Torokhov <dtor@chromium.org>
Tested-by: Dmitry Torokhov <dtor@chromium.org>

[modify] https://crrev.com/9e0e741702e34792aab82084e99157a717f0cd4a/crosh/crosh

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/83834b409dc03434ee9e8067d26dc2b8054c6672

commit 83834b409dc03434ee9e8067d26dc2b8054c6672
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Wed Apr 26 17:15:02 2017

crosh: make vmstat command accept options

To better aid in understanding memory access patterns on devices not
in dev mode, let's make vmstat command accept various options.

BUG=b:36197895, chromium:621711 
TEST=Try invoking vmstat in crosh

Change-Id: If0423bc0dd23d77da111b0bfa453edb0577ea3a5
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/479133
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 536619b70368ce8a49caeccb37e439ba2ef97a16)
Reviewed-on: https://chromium-review.googlesource.com/487865
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/83834b409dc03434ee9e8067d26dc2b8054c6672/crosh/crosh

Labels: -Hotlist-Merge-Review -Hotlist-Merge-Approved -Merge-Approved-59 Merge-Merged
Status: Fixed (was: Started)

Comment 20 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment