New issue
Advanced search Search tips

Issue 621691 link

Starred by 4 users
Status: WontFix
Owner: ----
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 725312


Sign in to add a comment

Measure interactive latency in WebRTC-protocol

Project Member Reported by sergeyu@chromium.org, Jun 20 2016 
Currently chromoting webapp measures, reports and logs latency for every input event. Need to implement the same functionality for the WebRTC-based protocol.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad51be89ed73cc6cdf56418ee9193a3a628b1f44

commit ad51be89ed73cc6cdf56418ee9193a3a628b1f44
Author: sergeyu <sergeyu@chromium.org>
Date: Wed Jun 22 06:04:39 2016

Replace VideoStream::SizeCallback with VideoStream::Observer interface.

The new Observer interface will allow to notify ClientSession when a
video frame is sent, which will allow to provide the client with the
frame_id->event_timestamp mapping.

BUG= 621691 

Review-Url: https://codereview.chromium.org/2083843002
Cr-Commit-Position: refs/heads/master@{#401214}

[modify] https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44/remoting/host/client_session.cc
[modify] https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44/remoting/host/client_session.h
[modify] https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44/remoting/host/client_session_unittest.cc
[modify] https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44/remoting/protocol/fake_connection_to_client.cc
[modify] https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44/remoting/protocol/fake_connection_to_client.h
[modify] https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44/remoting/protocol/video_frame_pump.cc
[modify] https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44/remoting/protocol/video_frame_pump.h
[modify] https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44/remoting/protocol/video_stream.h
[modify] https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44/remoting/protocol/webrtc_video_stream.cc
[modify] https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44/remoting/protocol/webrtc_video_stream.h
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a

commit 2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a
Author: sergeyu <sergeyu@chromium.org>
Date: Sat Jun 25 06:10:47 2016

Rework PerformanceTracker to make it usable with WebRTC

Previously PerformanceTracker was expected to be notified at the
moment when each frame is decoded and rendered. It also had
assumption that latest_event_timestamp is known for each frame
before that frame is rendered. That doesn't work with WebRTC
where frame stats will have to be sent separately from each
frame. With this change PerformanceTracker gets FrameStats
struct for each frame. That struct contains all timestamps for
the frame, which allows to log all relevant stats.

BUG= 621691 

Review-Url: https://codereview.chromium.org/2096643003
Cr-Commit-Position: refs/heads/master@{#402054}

[modify] https://crrev.com/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a/remoting/client/plugin/pepper_video_renderer_3d.cc
[modify] https://crrev.com/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a/remoting/client/plugin/pepper_video_renderer_3d.h
[modify] https://crrev.com/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a/remoting/client/software_video_renderer.cc
[modify] https://crrev.com/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a/remoting/client/software_video_renderer.h
[add] https://crrev.com/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a/remoting/protocol/frame_stats.cc
[add] https://crrev.com/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a/remoting/protocol/frame_stats.h
[modify] https://crrev.com/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a/remoting/protocol/performance_tracker.cc
[modify] https://crrev.com/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a/remoting/protocol/performance_tracker.h
[modify] https://crrev.com/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a/remoting/protocol/webrtc_video_renderer_adapter.cc
[modify] https://crrev.com/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a/remoting/protocol/webrtc_video_renderer_adapter.h
[modify] https://crrev.com/2ec2751edb7e5cec1d5c3ffa8899b3a281aa486a/remoting/remoting_srcs.gypi
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47dc4a536191dd62ec14d07f005da4be4c5d6aa1

commit 47dc4a536191dd62ec14d07f005da4be4c5d6aa1
Author: sergeyu <sergeyu@chromium.org>
Date: Wed Jul 06 21:07:22 2016

More cleanups in FrameStats

1. Separated HostFrameStats and ClientFrameStats. This will allow to
   track host and client stats separately.
2. Added FrameStatsConsumer interface to allow verify that FrameStats
   are generated correctly.
3. Added VideoRenderer::GetFrameStatsConsumer() and changed
   WebrtcVideoRendererAdapter to get VideoRenderer instead of
   FrameConsumer, so now the adapter can report FrameStats.

BUG= 621691 

Review-Url: https://codereview.chromium.org/2113523007
Cr-Commit-Position: refs/heads/master@{#403953}

[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/client/chromoting_client.h
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/client/jni/jni_video_renderer.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/client/jni/jni_video_renderer.h
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/client/plugin/pepper_video_renderer.h
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/client/plugin/pepper_video_renderer_2d.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/client/plugin/pepper_video_renderer_2d.h
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/client/plugin/pepper_video_renderer_3d.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/client/plugin/pepper_video_renderer_3d.h
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/client/software_video_renderer.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/client/software_video_renderer.h
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/protocol/fake_video_renderer.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/protocol/fake_video_renderer.h
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/protocol/frame_stats.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/protocol/frame_stats.h
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/protocol/performance_tracker.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/protocol/performance_tracker.h
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/protocol/video_renderer.h
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/protocol/webrtc_connection_to_host.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/protocol/webrtc_video_renderer_adapter.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/protocol/webrtc_video_renderer_adapter.h
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/test/protocol_perftest.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/test/test_chromoting_client.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/test/test_video_renderer.cc
[modify] https://crrev.com/47dc4a536191dd62ec14d07f005da4be4c5d6aa1/remoting/test/test_video_renderer.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d059c46f227d0a491f0ce2d4b8a302beda5533b3

commit d059c46f227d0a491f0ce2d4b8a302beda5533b3
Author: sergeyu <sergeyu@chromium.org>
Date: Wed Jul 20 19:34:10 2016

Add support for dynamic channels in WebrtcTransport.

Previously WebrtcTransport clients had to use incoming_channel_factory() to
accept incoming data channels. That worked only if the receiver knows in
advance names of all channels it can receive. Now the transport calls
EventHandler for incoming data channels, which allows the receiver to decide
dynamically if it wants to accept that channel. Also channels now can be
closed dynamically and the transport doesn't terminate connection when one
of the channels is closed.

BUG= 621691 

Review-Url: https://codereview.chromium.org/2146213002
Cr-Commit-Position: refs/heads/master@{#406639}

[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/channel_dispatcher_base.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/channel_dispatcher_base.h
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/client_video_dispatcher_unittest.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/connection_tester.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/connection_tester.h
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/connection_unittest.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/ice_connection_to_client.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/ice_connection_to_client.h
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/ice_connection_to_host.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/ice_connection_to_host.h
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/message_pipe.h
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/message_reader.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/stream_message_pipe_adapter.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/stream_message_pipe_adapter.h
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/webrtc_connection_to_client.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/webrtc_connection_to_client.h
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/webrtc_connection_to_host.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/webrtc_connection_to_host.h
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/webrtc_data_stream_adapter.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/webrtc_data_stream_adapter.h
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/webrtc_transport.cc
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/webrtc_transport.h
[modify] https://crrev.com/d059c46f227d0a491f0ce2d4b8a302beda5533b3/remoting/protocol/webrtc_transport_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/360f5baebcab5f3e464e52736f5013b2f8293d25

commit 360f5baebcab5f3e464e52736f5013b2f8293d25
Author: sergeyu <sergeyu@chromium.org>
Date: Fri Jul 22 18:54:45 2016

Add client and host dispatchers for video_stats channel to send video stats from host to client.

The new channel will be used with WebRTC protocol to send video stats to
client to make it possible to measure round-trip latency.

BUG= 621691 

Review-Url: https://codereview.chromium.org/2176443002
Cr-Commit-Position: refs/heads/master@{#407221}

[modify] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/base/constants.cc
[modify] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/base/constants.h
[modify] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/proto/BUILD.gn
[modify] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/proto/chromotocol.gyp
[add] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/proto/video_stats.proto
[modify] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/protocol/channel_dispatcher_base.cc
[modify] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/protocol/channel_dispatcher_base.h
[add] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/protocol/client_video_stats_dispatcher.cc
[add] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/protocol/client_video_stats_dispatcher.h
[modify] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/protocol/frame_stats.cc
[modify] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/protocol/frame_stats.h
[add] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/protocol/host_video_stats_dispatcher.cc
[add] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/protocol/host_video_stats_dispatcher.h
[add] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/protocol/video_stats_stub.h
[modify] https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25/remoting/remoting_srcs.gypi
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/19ee1e6eb102b2282a9993d6c373c7185ad9ba34

commit 19ee1e6eb102b2282a9993d6c373c7185ad9ba34
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Aug 01 20:35:55 2016

Add cricket::VideoFrame::transport_frame_id() and set it to RTP timestamp.

Passing transport_frame_id() to VideoSink will allow to identify incoming video
frames, which will make it possible to correlate video frames on the
sender and on the receiver.

BUG= chromium:621691 
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://codereview.webrtc.org/2088953002 .

Cr-Commit-Position: refs/heads/master@{#13596}

[modify] https://crrev.com/19ee1e6eb102b2282a9993d6c373c7185ad9ba34/webrtc/api/android/jni/androidvideocapturer_jni.cc
[modify] https://crrev.com/19ee1e6eb102b2282a9993d6c373c7185ad9ba34/webrtc/api/androidvideotracksource.cc
[modify] https://crrev.com/19ee1e6eb102b2282a9993d6c373c7185ad9ba34/webrtc/media/base/videobroadcaster.cc
[modify] https://crrev.com/19ee1e6eb102b2282a9993d6c373c7185ad9ba34/webrtc/media/base/videobroadcaster_unittest.cc
[modify] https://crrev.com/19ee1e6eb102b2282a9993d6c373c7185ad9ba34/webrtc/media/base/videoframe.h
[modify] https://crrev.com/19ee1e6eb102b2282a9993d6c373c7185ad9ba34/webrtc/media/base/videoframefactory.cc
[modify] https://crrev.com/19ee1e6eb102b2282a9993d6c373c7185ad9ba34/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/19ee1e6eb102b2282a9993d6c373c7185ad9ba34/webrtc/media/engine/webrtcvideoframe.cc
[modify] https://crrev.com/19ee1e6eb102b2282a9993d6c373c7185ad9ba34/webrtc/media/engine/webrtcvideoframe.h
[modify] https://crrev.com/19ee1e6eb102b2282a9993d6c373c7185ad9ba34/webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm
[modify] https://crrev.com/19ee1e6eb102b2282a9993d6c373c7185ad9ba34/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/ad34dbe934d47f88011045671b4aea00dbd5a795

commit ad34dbe934d47f88011045671b4aea00dbd5a795
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Aug 02 20:44:14 2016

Add EncodedImageCallback::OnEncodedImage().

OnEncodedImage() is going to replace Encoded(), which is deprecated now.
The new OnEncodedImage() returns Result struct that contains frame_id,
which tells the encoder RTP timestamp for the frame.

BUG= chromium:621691 
R=niklas.enbom@webrtc.org, sprang@webrtc.org, stefan@webrtc.org

Review URL: https://codereview.webrtc.org/2089773002 .

Cr-Commit-Position: refs/heads/master@{#13613}

[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/source/rtp_sender.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/rtp_rtcp/test/testAPI/test_api_video.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/codecs/test/videoprocessor.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/generic_encoder.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/generic_encoder.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/video_coding_impl.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/modules/video_coding/video_sender_unittest.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/test/fake_encoder.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/video/payload_router.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/video/payload_router.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/video/video_encoder_unittest.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/video/video_receive_stream.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/video/video_receive_stream.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/video/video_send_stream.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/video/video_send_stream.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/video/vie_encoder.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/video_encoder.h
[modify] https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795/webrtc/voice_engine/channel.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa

commit ac4dc2cefed816c84524a0c5b989e123d0ba2dfa
Author: sergeyu <sergeyu@chromium.org>
Date: Tue Aug 02 21:33:16 2016

Revert of Add EncodedImageCallback::OnEncodedImage(). (patchset #13 id:280001 of https://codereview.webrtc.org/2089773002/ )

Reason for revert:
broke internal tests

Original issue's description:
> Add EncodedImageCallback::OnEncodedImage().
>
> OnEncodedImage() is going to replace Encoded(), which is deprecated now.
> The new OnEncodedImage() returns Result struct that contains frame_id,
> which tells the encoder RTP timestamp for the frame.
>
> BUG= chromium:621691 
> R=niklas.enbom@webrtc.org, sprang@webrtc.org, stefan@webrtc.org
>
> Committed: https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795
> Cr-Commit-Position: refs/heads/master@{#13613}

TBR=pbos@webrtc.org,mflodman@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,niklas.enbom@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:621691 

Review-Url: https://codereview.webrtc.org/2206743002
Cr-Commit-Position: refs/heads/master@{#13614}

[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/source/rtp_sender.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/rtp_rtcp/test/testAPI/test_api_video.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/codecs/test/videoprocessor.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/generic_encoder.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/generic_encoder.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/video_coding_impl.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/modules/video_coding/video_sender_unittest.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/test/fake_encoder.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/video/payload_router.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/video/payload_router.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/video/video_encoder_unittest.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/video/video_receive_stream.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/video/video_receive_stream.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/video/video_send_stream.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/video/video_send_stream.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/video/vie_encoder.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/video_encoder.h
[modify] https://crrev.com/ac4dc2cefed816c84524a0c5b989e123d0ba2dfa/webrtc/voice_engine/channel.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/4c7f4cd2ef76821edca6d773d733a924b0bedd25

commit 4c7f4cd2ef76821edca6d773d733a924b0bedd25
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Aug 02 22:14:39 2016

Add EncodedImageCallback::OnEncodedImage().

OnEncodedImage() is going to replace Encoded(), which is deprecated now.
The new OnEncodedImage() returns Result struct that contains frame_id,
which tells the encoder RTP timestamp for the frame.

BUG= chromium:621691 
R=niklas.enbom@webrtc.org, sprang@webrtc.org, stefan@webrtc.org

Review URL: https://codereview.webrtc.org/2089773002 .

Committed: https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795
Cr-Original-Commit-Position: refs/heads/master@{#13613}
Cr-Commit-Position: refs/heads/master@{#13615}

[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/source/rtp_sender.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/rtp_rtcp/test/testAPI/test_api_video.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/codecs/test/videoprocessor.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/generic_encoder.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/generic_encoder.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/video_coding_impl.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/modules/video_coding/video_sender_unittest.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/test/fake_encoder.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/video/payload_router.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/video/payload_router.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/video/video_encoder_unittest.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/video/video_receive_stream.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/video/video_receive_stream.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/video/video_send_stream.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/video/video_send_stream.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/video/vie_encoder.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/video_encoder.h
[modify] https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25/webrtc/voice_engine/channel.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4

commit 51db4dd1bdf81dcd8cd1ced5dbad8807834611e4
Author: sergeyu <sergeyu@chromium.org>
Date: Wed Aug 03 00:33:42 2016

Revert of Add EncodedImageCallback::OnEncodedImage(). (patchset #14 id:300001 of https://codereview.chromium.org/2089773002/ )

Reason for revert:
broke browser_tests

Original issue's description:
> Add EncodedImageCallback::OnEncodedImage().
>
> OnEncodedImage() is going to replace Encoded(), which is deprecated now.
> The new OnEncodedImage() returns Result struct that contains frame_id,
> which tells the encoder RTP timestamp for the frame.
>
> BUG= chromium:621691 
> R=niklas.enbom@webrtc.org, sprang@webrtc.org, stefan@webrtc.org
>
> Committed: https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25
> Committed: https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795
> Cr-Original-Commit-Position: refs/heads/master@{#13613}
> Cr-Commit-Position: refs/heads/master@{#13615}

TBR=pbos@webrtc.org,mflodman@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,niklas.enbom@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:621691 

Review-Url: https://codereview.webrtc.org/2203233002
Cr-Commit-Position: refs/heads/master@{#13616}

[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/source/rtp_sender.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/rtp_rtcp/test/testAPI/test_api_video.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/codecs/test/videoprocessor.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/generic_encoder.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/generic_encoder.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/video_coding_impl.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/modules/video_coding/video_sender_unittest.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/test/fake_encoder.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/video/payload_router.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/video/payload_router.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/video/video_encoder_unittest.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/video/video_receive_stream.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/video/video_receive_stream.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/video/video_send_stream.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/video/video_send_stream.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/video/vie_encoder.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/video_encoder.h
[modify] https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4/webrtc/voice_engine/channel.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/525df3ffd1626efa0dc6be5824bc64297a0e9931

commit 525df3ffd1626efa0dc6be5824bc64297a0e9931
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Aug 03 00:46:41 2016

Add EncodedImageCallback::OnEncodedImage().

OnEncodedImage() is going to replace Encoded(), which is deprecated now.
The new OnEncodedImage() returns Result struct that contains frame_id,
which tells the encoder RTP timestamp for the frame.

BUG= chromium:621691 
R=niklas.enbom@webrtc.org, sprang@webrtc.org, stefan@webrtc.org

Review URL: https://codereview.webrtc.org/2089773002 .

Committed: https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25
Committed: https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795
Cr-Original-Original-Commit-Position: refs/heads/master@{#13613}
Cr-Original-Commit-Position: refs/heads/master@{#13615}
Cr-Commit-Position: refs/heads/master@{#13617}

[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/source/rtp_sender.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/rtp_rtcp/test/testAPI/test_api_video.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/codecs/test/videoprocessor.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/generic_encoder.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/generic_encoder.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/video_coding_impl.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/modules/video_coding/video_sender_unittest.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/test/fake_encoder.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/video/payload_router.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/video/payload_router.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/video/video_encoder_unittest.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/video/video_receive_stream.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/video/video_receive_stream.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/video/video_send_stream.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/video/video_send_stream.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/video/vie_encoder.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/video_encoder.h
[modify] https://crrev.com/525df3ffd1626efa0dc6be5824bc64297a0e9931/webrtc/voice_engine/channel.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09364636097f9c7b34349df97532291a2cfd015d

commit 09364636097f9c7b34349df97532291a2cfd015d
Author: sergeyu <sergeyu@chromium.org>
Date: Thu Aug 11 00:08:10 2016

Enable video stats reporting when using WebRTC

1. Host now initiating video_stats channel and uses it to send stats
   for each frame to the client
2. The client can accept video_stats channel and reports perf numbers
   to the FrameStatsConsumer.

BUG= 621691 

Review-Url: https://codereview.chromium.org/2200273003
Cr-Commit-Position: refs/heads/master@{#411196}

[modify] https://crrev.com/09364636097f9c7b34349df97532291a2cfd015d/remoting/protocol/connection_unittest.cc
[modify] https://crrev.com/09364636097f9c7b34349df97532291a2cfd015d/remoting/protocol/webrtc_connection_to_host.cc
[modify] https://crrev.com/09364636097f9c7b34349df97532291a2cfd015d/remoting/protocol/webrtc_connection_to_host.h
[modify] https://crrev.com/09364636097f9c7b34349df97532291a2cfd015d/remoting/protocol/webrtc_video_encoder_factory.cc
[modify] https://crrev.com/09364636097f9c7b34349df97532291a2cfd015d/remoting/protocol/webrtc_video_encoder_factory.h
[modify] https://crrev.com/09364636097f9c7b34349df97532291a2cfd015d/remoting/protocol/webrtc_video_renderer_adapter.cc
[modify] https://crrev.com/09364636097f9c7b34349df97532291a2cfd015d/remoting/protocol/webrtc_video_renderer_adapter.h
[modify] https://crrev.com/09364636097f9c7b34349df97532291a2cfd015d/remoting/protocol/webrtc_video_stream.cc
[modify] https://crrev.com/09364636097f9c7b34349df97532291a2cfd015d/remoting/protocol/webrtc_video_stream.h
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/fa565842718ad178a7562721b25d916fbabc2b92

commit fa565842718ad178a7562721b25d916fbabc2b92
Author: sergeyu <sergeyu@chromium.org>
Date: Wed Nov 02 20:14:16 2016

Remove deprected functions from EncodedImageCallback and RtpRtcp

Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData().
These methods should no longer be used anywhere and it's safe to remove
them.

BUG= chromium:621691 

Review-Url: https://codereview.webrtc.org/2405173006
Cr-Commit-Position: refs/heads/master@{#14902}

[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/api/android/jni/androidmediaencoder_jni.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/modules/video_coding/codecs/i420/i420.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/modules/video_coding/video_receiver.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/test/configurable_frame_size_encoder.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92/webrtc/video_encoder.h
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/6c78307a21252c2dbd704f6d5e92a220fb722ed4

commit 6c78307a21252c2dbd704f6d5e92a220fb722ed4
Author: ehmaldonado <ehmaldonado@webrtc.org>
Date: Thu Nov 03 14:33:17 2016

Revert of Remove deprected functions from EncodedImageCallback and RtpRtcp (patchset #4 id:100001 of https://codereview.webrtc.org/2405173006/ )

Reason for revert:
This might be breaking projects downstream.

Original issue's description:
> Remove deprected functions from EncodedImageCallback and RtpRtcp
>
> Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData().
> These methods should no longer be used anywhere and it's safe to remove
> them.
>
> BUG= chromium:621691 
>
> Committed: https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92
> Cr-Commit-Position: refs/heads/master@{#14902}

TBR=mflodman@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:621691 

Review-Url: https://codereview.webrtc.org/2474433008
Cr-Commit-Position: refs/heads/master@{#14914}

[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/api/android/jni/androidmediaencoder_jni.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/modules/video_coding/codecs/i420/i420.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/modules/video_coding/video_receiver.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/test/configurable_frame_size_encoder.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4/webrtc/video_encoder.h
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/a1d6cd64083a3c0173aeefe38425a56de8942745

commit a1d6cd64083a3c0173aeefe38425a56de8942745
Author: ehmaldonado <ehmaldonado@webrtc.org>
Date: Thu Nov 03 14:38:59 2016

Reland of move deprected functions from EncodedImageCallback and RtpRtcp (patchset #2 id:240001 of https://codereview.webrtc.org/2474433008/ )

Reason for revert:
Breaks everything

Original issue's description:
> Revert of Remove deprected functions from EncodedImageCallback and RtpRtcp (patchset #4 id:100001 of https://codereview.webrtc.org/2405173006/ )
>
> Reason for revert:
> This might be breaking projects downstream.
>
> Original issue's description:
> > Remove deprected functions from EncodedImageCallback and RtpRtcp
> >
> > Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData().
> > These methods should no longer be used anywhere and it's safe to remove
> > them.
> >
> > BUG= chromium:621691 
> >
> > Committed: https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92
> > Cr-Commit-Position: refs/heads/master@{#14902}
>
> TBR=mflodman@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= chromium:621691 
>
> Committed: https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4
> Cr-Commit-Position: refs/heads/master@{#14914}

TBR=mflodman@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:621691 

Review-Url: https://codereview.webrtc.org/2467373003
Cr-Commit-Position: refs/heads/master@{#14915}

[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/api/android/jni/androidmediaencoder_jni.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/modules/video_coding/codecs/i420/i420.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/modules/video_coding/video_receiver.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/test/configurable_frame_size_encoder.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745/webrtc/video_encoder.h
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/43a9dc0f93e1c8c822c55bcb89b9f0f746354651

commit 43a9dc0f93e1c8c822c55bcb89b9f0f746354651
Author: ehmaldonado <ehmaldonado@webrtc.org>
Date: Thu Nov 03 14:52:36 2016

Revert of move deprected functions from EncodedImageCallback and RtpRtcp (patchset #1 id:1 of https://codereview.webrtc.org/2467373003/ )

Reason for revert:
Made a mistake while reverting.

Original issue's description:
> Reland of move deprected functions from EncodedImageCallback and RtpRtcp (patchset #2 id:240001 of https://codereview.webrtc.org/2474433008/ )
>
> Reason for revert:
> Breaks everything
>
> Original issue's description:
> > Revert of Remove deprected functions from EncodedImageCallback and RtpRtcp (patchset #4 id:100001 of https://codereview.webrtc.org/2405173006/ )
> >
> > Reason for revert:
> > This might be breaking projects downstream.
> >
> > Original issue's description:
> > > Remove deprected functions from EncodedImageCallback and RtpRtcp
> > >
> > > Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData().
> > > These methods should no longer be used anywhere and it's safe to remove
> > > them.
> > >
> > > BUG= chromium:621691 
> > >
> > > Committed: https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92
> > > Cr-Commit-Position: refs/heads/master@{#14902}
> >
> > TBR=mflodman@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG= chromium:621691 
> >
> > Committed: https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4
> > Cr-Commit-Position: refs/heads/master@{#14914}
>
> TBR=mflodman@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= chromium:621691 
>
> Committed: https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745
> Cr-Commit-Position: refs/heads/master@{#14915}

TBR=mflodman@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:621691 

Review-Url: https://codereview.webrtc.org/2477773002
Cr-Commit-Position: refs/heads/master@{#14916}

[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/api/android/jni/androidmediaencoder_jni.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/modules/video_coding/codecs/i420/i420.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/modules/video_coding/video_receiver.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/test/configurable_frame_size_encoder.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651/webrtc/video_encoder.h
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/c681250aaa2025836db7669694e323898e5c2ca7

commit c681250aaa2025836db7669694e323898e5c2ca7
Author: sergeyu <sergeyu@chromium.org>
Date: Thu Nov 03 18:06:38 2016

Remove deprected functions from EncodedImageCallback and RtpRtcp

Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData().
These methods should no longer be used anywhere and it's safe to remove
them.

BUG= chromium:621691 

Review-Url: https://codereview.webrtc.org/2405173006
Cr-Commit-Position: refs/heads/master@{#14923}

[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/api/android/jni/androidmediaencoder_jni.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/modules/video_coding/codecs/i420/i420.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/modules/video_coding/video_receiver.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/test/configurable_frame_size_encoder.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7/webrtc/video_encoder.h
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/91b957d3e4a7a8266468df2d315b5e6db441ec1e

commit 91b957d3e4a7a8266468df2d315b5e6db441ec1e
Author: kjellander <kjellander@webrtc.org>
Date: Thu Nov 03 18:53:43 2016

Revert of Remove deprected functions from EncodedImageCallback and RtpRtcp (patchset #4 id:100001 of https://codereview.webrtc.org/2405173006/ )

Reason for revert:
Still breaks internal downstream project.
Sergey: Please update internal project before relanding this.

Original issue's description:
> Remove deprected functions from EncodedImageCallback and RtpRtcp
>
> Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData().
> These methods should no longer be used anywhere and it's safe to remove
> them.
>
> BUG= chromium:621691 
>
> Committed: https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7
> Cr-Commit-Position: refs/heads/master@{#14923}

TBR=mflodman@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:621691 

Review-Url: https://codereview.webrtc.org/2479643002
Cr-Commit-Position: refs/heads/master@{#14925}

[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/api/android/jni/androidmediaencoder_jni.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/modules/video_coding/codecs/i420/i420.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/modules/video_coding/video_receiver.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/test/configurable_frame_size_encoder.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/91b957d3e4a7a8266468df2d315b5e6db441ec1e/webrtc/video_encoder.h
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7

commit 2cb155aa8a6c3d432dee7384fcbc01ec742b00a7
Author: sergeyu <sergeyu@chromium.org>
Date: Fri Nov 04 18:39:29 2016

Remove deprected functions from EncodedImageCallback and RtpRtcp

Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData().
These methods should no longer be used anywhere and it's safe to remove
them.

BUG= chromium:621691 

Committed: https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7
Review-Url: https://codereview.webrtc.org/2405173006
Cr-Original-Commit-Position: refs/heads/master@{#14923}
Cr-Commit-Position: refs/heads/master@{#14935}

[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/api/android/jni/androidmediaencoder_jni.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/i420/i420.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/video_receiver.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/test/configurable_frame_size_encoder.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/video_encoder.h
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7

commit 2cb155aa8a6c3d432dee7384fcbc01ec742b00a7
Author: sergeyu <sergeyu@chromium.org>
Date: Fri Nov 04 18:39:29 2016

Remove deprected functions from EncodedImageCallback and RtpRtcp

Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData().
These methods should no longer be used anywhere and it's safe to remove
them.

BUG= chromium:621691 

Committed: https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7
Review-Url: https://codereview.webrtc.org/2405173006
Cr-Original-Commit-Position: refs/heads/master@{#14923}
Cr-Commit-Position: refs/heads/master@{#14935}

[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/api/android/jni/androidmediaencoder_jni.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/i420/i420.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/modules/video_coding/video_receiver.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/test/configurable_frame_size_encoder.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/test/fake_encoder.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/video/payload_router_unittest.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/video/vie_encoder_unittest.cc
[modify] https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7/webrtc/video_encoder.h

Comment 21 by sergeyu@chromium.org, Mar 29 2017

Blockedon: 695223

Comment 22 by sergeyu@chromium.org, Dec 1 2017

Owner: ----
Status: Unti (was: Started)

Comment 23 by sergeyu@chromium.org, Dec 1 2017

Status: Untiaged (was: Unti)

Comment 24 by sergeyu@chromium.org, Dec 1 2017

Status: Untriaged (was: Untiaged)

Comment 25 by jamiewa...@chromium.org, Dec 14 2017

Blockedon: -695223 725312
Sergey, the bug this is blocked on ( bug 725312 ) is currently owned by you. Are you still planning on working on that, or should that be reassigned as well?

Comment 26 by sergeyu@google.com, Dec 14 2017 

I've just closed 725312 as WontFix - we are not going to implement that API the way it was specified. To implement proper perf tracking with WebRTC for chromoting we'd still need to add to some web API, e.g. as an extension to Perf Timeline API. Nobody is working on it right now.

Comment 27 by jamiewa...@chromium.org, Jan 9 2018

Status: WontFix (was: Untriaged)
The data from the Chrome didn't prove to be very useful, so I don't think this is something we'd prioritize for now.
►

Sign in to add a comment