General Sync Settings Polish |
|||||||||
Issue descriptionOn top level click on Sync to get to Sync Settings Page: (1) Disabled checkbox color should be google blue 500 Click "Encrypt all synced data with your own sync passphrase" under "Encryption options": (2) Save" button internal padding incorrect (3) Put more spacing above the “Save” button (4) Passphrase controls too close to edge of page (5) Passphrase / Confirm passphrase textbox font-size / focused color are off
,
Jun 21 2016
,
Oct 14 2016
Not CrOS specific.
,
Oct 18 2016
I am un-assigning myself for now to allow others to grab this while I am busy with crbug.com/639718 .
,
Oct 18 2016
hey Moe, any extra cycles to help with this while tommycli@ is OOO?
,
Oct 18 2016
I may be able to get to it this week. Could you by any chance provide the link to the relevant mocks?
,
Oct 18 2016
Alan, could could look into the following questions/comments? (1) paper-checkbox uses the same color for the unchecked and disabled states. it's hard to override that without dirty tricks. (2) how much spacing? (3) what is the desired padding for '.action-button'? (4) is this still valid? (5) what is the desired textbox font-size?
,
Oct 18 2016
,
Oct 18 2016
,
Oct 20 2016
Alan, please note the screenshots included in the CL: https://codereview.chromium.org/2441503002
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23efaf6aa7ffc0c186772321cce481f90160a9a6 commit 23efaf6aa7ffc0c186772321cce481f90160a9a6 Author: mahmadi <mahmadi@chromium.org> Date: Wed Oct 26 21:56:56 2016 [MD Settings][People] Visual updates to the sync setup page. screenshots: https://screenshot.googleplex.com/gnDB2qGYufo https://screenshot.googleplex.com/yXPegOqyNnK https://screenshot.googleplex.com/LBQZ1uzYLjt https://screenshot.googleplex.com/mooGsad6fjJ https://screenshot.googleplex.com/0SGpgoeW6Bg BUG= 621683 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2441503002 Cr-Commit-Position: refs/heads/master@{#427833} [modify] https://crrev.com/23efaf6aa7ffc0c186772321cce481f90160a9a6/chrome/app/generated_resources.grd [modify] https://crrev.com/23efaf6aa7ffc0c186772321cce481f90160a9a6/chrome/app/settings_strings.grdp [modify] https://crrev.com/23efaf6aa7ffc0c186772321cce481f90160a9a6/chrome/browser/resources/settings/people_page/sync_page.html [modify] https://crrev.com/23efaf6aa7ffc0c186772321cce481f90160a9a6/chrome/browser/resources/settings/people_page/sync_page.js [modify] https://crrev.com/23efaf6aa7ffc0c186772321cce481f90160a9a6/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/23efaf6aa7ffc0c186772321cce481f90160a9a6/chrome/browser/ui/webui/settings/people_handler.cc [modify] https://crrev.com/23efaf6aa7ffc0c186772321cce481f90160a9a6/chrome/test/data/webui/settings/people_page_sync_page_test.js
,
Oct 26 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mgreenwald@google.com
, Jun 20 2016