@sshruthi - should this and the other couple of bugs I just filed be Type=Launch ?

I don't think this needs to be a launch bug, since we don't really need the approvals that those go through. Can you guys think of anything in here that needs any of the launch-related approvals (UI, privacy, legal, test, for instance)?

No, I don't think there's anything specifically needed for approvals, since GN is an essentially internal change.

 Issue 517496  has been merged into this issue.

won't make M-53

Closing this.

I'm going to try tracking ship-blocking things via the label "Proj-GN-Migration-Ship" (instead of Proj-GN-Migration) as suggested w/ a conversation w/ laforge@ and the monorail folks a while ago.

Querying for "Proj=GN-Migration%" should still return bugs for both labels, and this will allow us to filter out rollup things more easily, so that we can use blocking just for things that are truly blocking other bugs.

I am actually going to re-purpose of this to track the actual flipping of the switch to make GN the default on Chrome OS builders.

CL is ready! https://chromium-review.googlesource.com/#/c/358101/

Tryjobs:
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/chrome-pfq
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/chromium-pfq

FWIW, the unstripped chrome binary for samus is 5448 MB with GN vs 5290 MB with GYP, so worse case it is an extra 160 MB, but it is probably less stripped.

I will compare image sizes next.

You should definitely not expect unstripped binaries to be the same size between GYP and GN, due to the changes from static_libraries to source_sets.

OK, this is effectively done. The CL landed and the PFQ builders do not appear to have any GN related issues...