Debugged this quickly.

This seems to be failing because of the m_lastFindRequestCompletedWithNoMatches optimization in TextFinder::shouldScopeMatches(). I think that means we don't even attempt to re-search the document.

It is fixed if I (using the debugger) manually force m_lastFindRequestCompletedWithNoMatches to false, or if I force reallocation of the TextFinder to a new instance.

M51 works fine with these same repro steps. Should we discard the TextFinder when we load a new document?

Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Same bug is on windows chrome too (Version 53.0.2783.2 dev-m) while a bit different. In step 4 (control+f) the find box is frozen. No "0 of 0" appears and generally search is stuck. The only way to generate a result is to delete the current search text and replace it with another. This is a very annoying bug to users who use search all the time.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f06e61927d77b49240266b75710908c8bf3710b

commit 2f06e61927d77b49240266b75710908c8bf3710b
Author: paulmeyer <paulmeyer@chromium.org>
Date: Wed Aug 10 17:39:02 2016

Some changes to the testing infrastructure in find_request_manager_browsertest.cc.

These changes will improve on some (very) occasional flakyness that I've noticed in the tests in there. They are also completely necessary for a test to work that will be added soon in an upcoming CL.

BUG= 621660 

Review-Url: https://codereview.chromium.org/2223063005
Cr-Commit-Position: refs/heads/master@{#411071}

[modify] https://crrev.com/2f06e61927d77b49240266b75710908c8bf3710b/content/browser/find_request_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1

commit ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1
Author: paulmeyer <paulmeyer@chromium.org>
Date: Fri Sep 23 20:25:34 2016

Handling new frames and frame navigations with find-in-page during a find session.

This patch implements new find-in-page functionality that allows for frames that are either newly added or navigated during a find session to be automatically searched so that matches in their new content are automatically highlighted and included in the results shown in the find bar.

Also, there is a fix included in this patch to prevent the find-in-page bar from closing when a subframe navigates (the find session should only end if the main frame navigates).

Design doc: https://docs.google.com/document/d/1r4F19FIKg4zPJCaSyJ9-T0sgFbxlCGKL3FjqQEAKegg/view

BUG= 2220 , 621660 

Review-Url: https://codereview.chromium.org/2236403004
Cr-Commit-Position: refs/heads/master@{#420715}

[modify] https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1/chrome/browser/ui/find_bar/find_bar_controller.cc
[modify] https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1/content/browser/find_request_manager.cc
[modify] https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1/content/browser/find_request_manager.h
[modify] https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1/content/browser/find_request_manager_browsertest.cc
[modify] https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1/content/common/frame_messages.h
[modify] https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1/third_party/WebKit/Source/web/TextFinder.h
[modify] https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1/third_party/WebKit/public/web/WebFindOptions.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cab0f2e9bc64a1caf21877b36972a30212c685e6

commit cab0f2e9bc64a1caf21877b36972a30212c685e6
Author: gcasto <gcasto@chromium.org>
Date: Fri Sep 23 23:16:05 2016

Revert of Handling new frames and frame navigations with find-in-page during a find session. (patchset #2 id:120001 of https://codereview.chromium.org/2236403004/ )

Reason for revert:
This seems to be failing pretty consistently on some bots (e.g. https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29)

Original issue's description:
> Handling new frames and frame navigations with find-in-page during a find session.
>
> This patch implements new find-in-page functionality that allows for frames that are either newly added or navigated during a find session to be automatically searched so that matches in their new content are automatically highlighted and included in the results shown in the find bar.
>
> Also, there is a fix included in this patch to prevent the find-in-page bar from closing when a subframe navigates (the find session should only end if the main frame navigates).
>
> Design doc: https://docs.google.com/document/d/1r4F19FIKg4zPJCaSyJ9-T0sgFbxlCGKL3FjqQEAKegg/view
>
> BUG= 2220 , 621660 
>
> Committed: https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1
> Cr-Commit-Position: refs/heads/master@{#420715}

TBR=dcheng@chromium.org,pkasting@chromium.org,kenrb@chromium.org,paulmeyer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 2220 , 621660 

Review-Url: https://codereview.chromium.org/2363993003
Cr-Commit-Position: refs/heads/master@{#420774}

[modify] https://crrev.com/cab0f2e9bc64a1caf21877b36972a30212c685e6/chrome/browser/ui/find_bar/find_bar_controller.cc
[modify] https://crrev.com/cab0f2e9bc64a1caf21877b36972a30212c685e6/content/browser/find_request_manager.cc
[modify] https://crrev.com/cab0f2e9bc64a1caf21877b36972a30212c685e6/content/browser/find_request_manager.h
[modify] https://crrev.com/cab0f2e9bc64a1caf21877b36972a30212c685e6/content/browser/find_request_manager_browsertest.cc
[modify] https://crrev.com/cab0f2e9bc64a1caf21877b36972a30212c685e6/content/common/frame_messages.h
[modify] https://crrev.com/cab0f2e9bc64a1caf21877b36972a30212c685e6/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/cab0f2e9bc64a1caf21877b36972a30212c685e6/third_party/WebKit/Source/web/TextFinder.h
[modify] https://crrev.com/cab0f2e9bc64a1caf21877b36972a30212c685e6/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/cab0f2e9bc64a1caf21877b36972a30212c685e6/third_party/WebKit/public/web/WebFindOptions.h

(Re-opening due to the revert)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ac612d592cd42355a432c8d307051d299d79768

commit 3ac612d592cd42355a432c8d307051d299d79768
Author: paulmeyer <paulmeyer@chromium.org>
Date: Fri Sep 30 19:21:06 2016

Handling new frames and frame navigations with find-in-page during a find
session.

This patch implements new find-in-page functionality that allows for frames
that are either newly added or navigated during a find session to be
automatically searched so that matches in their new content are
automatically highlighted and included in the results shown in the find bar.

Also, there is a fix included in this patch to prevent the find-in-page bar
from closing when a subframe navigates (the find session should only end if
the main frame navigates).

Design doc: https://docs.google.com/document/d/1r4F19FIKg4zPJCaSyJ9-T0sgFbxlCGKL3FjqQEAKegg/view

This is a reland of: https://codereview.chromium.org/2236403004/

BUG= 2220 ,  621660 

TBR=dcheng@chromium.org,pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2384483004
Cr-Commit-Position: refs/heads/master@{#422176}

[modify] https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768/chrome/browser/ui/find_bar/find_bar_controller.cc
[modify] https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768/content/browser/find_request_manager.cc
[modify] https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768/content/browser/find_request_manager.h
[modify] https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768/content/browser/find_request_manager_browsertest.cc
[modify] https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768/content/common/frame_messages.h
[modify] https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768/third_party/WebKit/Source/web/TextFinder.h
[modify] https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768/third_party/WebKit/public/web/WebFindOptions.h