New issue
Advanced search Search tips

Issue 621630 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 15
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

content_junit_tests target does not include all tests

Reported by kra...@amazon.com, Jun 20 2016

Issue description

Version: Tip of master
OS: Android

What steps will reproduce the problem?
(1) Build and run content_junit_tests

What is the expected output?
31/31 tests pass
Tests include:
- GamepadMappingsTest
- RangeTest
- TextInputStateTest
- ThreadedInputConnectionTest
- BindingManagerImplTest

What do you see instead?
21/21 tests pass
Missing tests:
- RangeTest
- TextInputStateTest
- ThreadedInputConnectionTest

Please use labels and text to provide additional information.
See https://cs.chromium.org/chromium/src/content/public/android/BUILD.gn?sq=package:chromium&dr=C for tests that run
See https://cs.chromium.org/chromium/src/content/public/android/junit/src/org/chromium/content/browser/?q=ThreadedInputConnectionTest.java&sq=package:chromium for tests that exist

 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/472201e210c18ff0bef1e4e17accff896966ff1b

commit 472201e210c18ff0bef1e4e17accff896966ff1b
Author: kraush <kraush@amazon.com>
Date: Wed Jun 22 02:51:01 2016

Add all content_junit tests to GN config

This change adds all the content_junit tests to their
GN config and adjusts ThreadedInputConnectionTest to
work with the fact that it is now based on
BaseInputConnection

BUG= 621630 

Review-Url: https://codereview.chromium.org/2082783002
Cr-Commit-Position: refs/heads/master@{#401181}

[modify] https://crrev.com/472201e210c18ff0bef1e4e17accff896966ff1b/content/public/android/BUILD.gn
[modify] https://crrev.com/472201e210c18ff0bef1e4e17accff896966ff1b/content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java

Status: Fixed (was: Untriaged)

Sign in to add a comment