Remove enable_alternative_service_for_insecure_origins. |
||
Issue descriptionenable_alternative_service_for_insecure_origins is test only and is meant as a temporary workaround. It needs to be removed. Note that many tests currently request http://somehost and upgrade to https to the same host. By simply making the request https, the tests fail, because the alternative service would be identical to the request. Therefore issue 615413 needs to be fixed first, so that alternative services can be enabled for different hosts, so that these tests can be rewritten to use a different alternative host. (Another option would be to use different ports for https for origin and alternative, but that is not very aesthetic.)
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f commit b2602438cbcdd99e6eb34d8be9c54d65e8bf087f Author: bnc <bnc@chromium.org> Date: Wed Jun 29 02:39:45 2016 Change a number of SPDY unittests from http to https. * Remove enable_alternative_service_for_insecure_origins; * change alternative service unittests from http to https; * change kDefaultUrl from http to https; * s/kDefaultURL/kDefaultUrl/ (to match the one in QuicStreamFactoryTest); * adapt a number of tests, explicitly use old URL in others; * remove SpdyTestUtil::default_url(); * remove moot SpdyAlternativeServiceThroughProxy; * remove SpdyNetworkTransactionTest::GetDefaultUrl() and port_; * add SpdyNetworkTransactionTest members to make tests more concise. Besides an improvement in code health, this CL will make it easier to write unittests for https://crbug.com/615413. BUG= 621621 , 624073 Review-Url: https://codereview.chromium.org/2109803002 Cr-Commit-Position: refs/heads/master@{#402686} [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_network_session.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_network_session.h [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_network_transaction.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_network_transaction_unittest.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_stream_factory_impl_job.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_stream_factory_impl_job_controller.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/http/http_stream_factory_impl_request_unittest.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/quic/quic_network_transaction_unittest.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_http_stream_unittest.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_network_transaction_unittest.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_session_unittest.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_stream_unittest.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_test_util_common.cc [modify] https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f/net/spdy/spdy_test_util_common.h
,
Jun 30 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by b...@chromium.org
, Jun 27 2016