New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621614 link

Starred by 2 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
maxwalker@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Divider dimensions and color incorrect for new EVCert

Project Member Reported by shrike@chromium.org, Jun 20 2016 
Version: 53.0.2769.0
OS: 10.11

The divider should be 1px x 16pt and #000 35%. On Retina the divider is currently 2px wide and a lighter shade of gray (probably #000 20%).
20875d2f-a2cd-4a59-9b5f-031e43af2d1d.png
86.7 KB View Download
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 21 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 4 2016

Labels: -M-53 -Pri-1 M-54 MovedFrom-53 Pri-2
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by maxwalker@chromium.org, Oct 17 2016 

Attaching color spec for incognito mode:
Incognito.png
57.9 KB View Download

Comment 4 by maxwalker@chromium.org, Oct 17 2016 

Could you also take a look at the tab-to-search divider, please? It should be the same size and color. Thanks!
Search.png
215 KB View Download

Comment 5 by shrike@chromium.org, Oct 17 2016

Labels: -M-54 M-56

Comment 6 by spqc...@chromium.org, Mar 31 2017

Cc: -shrike@chromium.org
Owner: shrike@chromium.org
This needs to be fixed for the popup blocker too. Assigning to shrike@

Comment 7 by shrike@chromium.org, May 5 2017

Labels: -M-56 M-60
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1ce80a582eece54780574857e8fdb8d7cef1acf

commit f1ce80a582eece54780574857e8fdb8d7cef1acf
Author: shrike <shrike@chromium.org>
Date: Mon May 08 16:23:36 2017

[Mac] Refactor decoration divider code.

Reorganizes the code that draws decoration dividers into a single
method.

R=spqchan@chromium.org,avi@chromium.org
BUG= 621614 , 719083 

Review-Url: https://codereview.chromium.org/2861283002
Cr-Commit-Position: refs/heads/master@{#470004}

[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.h
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

Comment 9 by shrike@chromium.org, May 8 2017

Status: Fixed (was: Started)
►

Sign in to add a comment