Focus ring paints incorrectly on iron-list unless the content scrolls |
|||||
Issue descriptionGoogle Chrome 53.0.2773.0 (Official Build) canary (64-bit) Revision ced2fcee2c85702055d028f4e3e48c5a75a7e41c-refs/heads/master@{#400610} OS Mac OS X This is on my Retina MBP. What steps will reproduce the problem? (1) Load https://elements.polymer-project.org/elements/iron-list?view=demo:demo/collapse.html&active=iron-list (2) Click an item so a blue ring shows up around it. (3) Press the down arrow key a few times, notice only the bottom of the box is blue. (4) Press the up arrow key notice the ring is fine when the content scrolls. If you hover the ring will also get corrected because of the little [+] appearing causing a repaint.
,
Jun 20 2016
I'd hazard a guess that it is. I'll take a look.
,
Jun 20 2016
Note that you get a thinner than expected outline in Linux, rather than no outline at all.
,
Jun 23 2016
,
Jun 23 2016
,
Jun 26 2016
,
Jun 26 2016
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3faa9d5121f4e933c111e8e3aca23f1fd5e3ba25 commit 3faa9d5121f4e933c111e8e3aca23f1fd5e3ba25 Author: robhogan <robhogan@gmail.com> Date: Mon Jun 27 18:55:35 2016 Update composited layer size if overflow from children requires it If a change to an element's overflow requires the composited layer that paints it to expand in size then we need to make sure that expansion happens. Before, it was assured by layout. Now that we skip layout if overflow is the only thing that has changed we need to watch for the need to expand the layer when we compute overflow. BUG= 621612 Review-Url: https://codereview.chromium.org/2098223002 Cr-Commit-Position: refs/heads/master@{#402242} [add] https://crrev.com/3faa9d5121f4e933c111e8e3aca23f1fd5e3ba25/third_party/WebKit/LayoutTests/fast/repaint/overflow-changed-on-child-of-composited-layer-expected.html [add] https://crrev.com/3faa9d5121f4e933c111e8e3aca23f1fd5e3ba25/third_party/WebKit/LayoutTests/fast/repaint/overflow-changed-on-child-of-composited-layer-expected.txt [add] https://crrev.com/3faa9d5121f4e933c111e8e3aca23f1fd5e3ba25/third_party/WebKit/LayoutTests/fast/repaint/overflow-changed-on-child-of-composited-layer.html [modify] https://crrev.com/3faa9d5121f4e933c111e8e3aca23f1fd5e3ba25/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
,
Jul 4 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 17 2016
Is this bug fixed?
,
Dec 14 2016
,
Dec 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d271bad92f0eadddc4fd92d0a99ad5c7ae77b5dd commit d271bad92f0eadddc4fd92d0a99ad5c7ae77b5dd Author: Chris Harrelson <chrishtr@chromium.org> Date: Thu Dec 28 21:59:32 2017 [PE] Fix code that dirties compositing inputs when overflow changes. The old code had two problems: 1. If a child of a PaintLayer needed overflow, then the PaintLayer's overflow is already recomputed anyway, so there is no reason to reach into the EnclosingLayer(). 2. The visual overflow a child may not be in the same coordinate space of its containing PaintLayer. Bug: 621612 Original patch was: https://codereview.chromium.org/2098223002 Change-Id: Ie6675bbb1c7f95ce38a1d629f67153d18de39537 Reviewed-on: https://chromium-review.googlesource.com/845054 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526330} [add] https://crrev.com/d271bad92f0eadddc4fd92d0a99ad5c7ae77b5dd/third_party/WebKit/LayoutTests/paint/invalidation/overflow/overflow-changed-on-child-of-squashed-layer-expected.html [add] https://crrev.com/d271bad92f0eadddc4fd92d0a99ad5c7ae77b5dd/third_party/WebKit/LayoutTests/paint/invalidation/overflow/overflow-changed-on-child-of-squashed-layer.html [modify] https://crrev.com/d271bad92f0eadddc4fd92d0a99ad5c7ae77b5dd/third_party/WebKit/Source/core/layout/LayoutBlock.cpp |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by wangxianzhu@chromium.org
, Jun 20 2016