New issue
Advanced search Search tips

Issue 621604 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The predictor loses all data on unclean shutdown

Project Member Reported by csharrison@chromium.org, Jun 20 2016

Issue description

The net predictor clears its DB on startup, and holds all data in memory until clean shutdown.

If unclean shutdown happens, we completely lose all data. Instead, let's not clear the prefs on startup.

Additionally, we could be updating the prefs more often (see  crbug.com/78451  with a solution to that).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2113bc361ed6ad09f2e97ef5068be4e8c32e114

commit f2113bc361ed6ad09f2e97ef5068be4e8c32e114
Author: csharrison <csharrison@chromium.org>
Date: Wed Jun 29 15:07:55 2016

Don't clear the net predictors prefs on startup

Traditionally, the net predictor had its database cleared from preferences
during startup, deleting them while transfering to a completely in-memory
representation.

This is non-ideal for Android, where unclean shutdowns are more common due
to oom-killer.

This patch removes the behavior in favor of clearing the prefs when the user
clears browsing history. Note that in order to properly persist db updates
in the presence of unclean shutdowns, we will have to sync the prefs more
often. This will be implemented as a follow up.

BUG= 621604 

Review-Url: https://codereview.chromium.org/2085643002
Cr-Commit-Position: refs/heads/master@{#402813}

[modify] https://crrev.com/f2113bc361ed6ad09f2e97ef5068be4e8c32e114/chrome/browser/browsing_data/browsing_data_remover.cc
[modify] https://crrev.com/f2113bc361ed6ad09f2e97ef5068be4e8c32e114/chrome/browser/chrome_net_benchmarking_message_filter.cc
[modify] https://crrev.com/f2113bc361ed6ad09f2e97ef5068be4e8c32e114/chrome/browser/chrome_net_benchmarking_message_filter.h
[modify] https://crrev.com/f2113bc361ed6ad09f2e97ef5068be4e8c32e114/chrome/browser/net/predictor.cc
[modify] https://crrev.com/f2113bc361ed6ad09f2e97ef5068be4e8c32e114/chrome/browser/net/predictor.h
[modify] https://crrev.com/f2113bc361ed6ad09f2e97ef5068be4e8c32e114/chrome/browser/net/predictor_browsertest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1 2016

Status: Fixed (was: Started)

Sign in to add a comment