The predictor loses all data on unclean shutdown |
||
Issue descriptionThe net predictor clears its DB on startup, and holds all data in memory until clean shutdown. If unclean shutdown happens, we completely lose all data. Instead, let's not clear the prefs on startup. Additionally, we could be updating the prefs more often (see crbug.com/78451 with a solution to that).
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee45633faa3fae0320db4b630ec24221e930478e commit ee45633faa3fae0320db4b630ec24221e930478e Author: csharrison <csharrison@chromium.org> Date: Mon Aug 01 19:20:03 2016 Use lossy prefs in the net predictor, and update them more frequently This patch changes the predictor to use lossy prefs to sync referrer lists, and updates them upon receiving the load event from a main frame document. This fixes an issue where prefs are not updated on unclean shutdown, and a hang during a synchronous thread hop roundtrip. BUG= 78451 , 621604 Review-Url: https://codereview.chromium.org/2084093002 Cr-Commit-Position: refs/heads/master@{#409017} [modify] https://crrev.com/ee45633faa3fae0320db4b630ec24221e930478e/chrome/browser/net/predictor.cc [modify] https://crrev.com/ee45633faa3fae0320db4b630ec24221e930478e/chrome/browser/net/predictor.h [modify] https://crrev.com/ee45633faa3fae0320db4b630ec24221e930478e/chrome/browser/net/predictor_browsertest.cc [modify] https://crrev.com/ee45633faa3fae0320db4b630ec24221e930478e/chrome/browser/net/predictor_tab_helper.cc [modify] https://crrev.com/ee45633faa3fae0320db4b630ec24221e930478e/chrome/browser/net/predictor_tab_helper.h [modify] https://crrev.com/ee45633faa3fae0320db4b630ec24221e930478e/chrome/browser/net/predictor_unittest.cc [modify] https://crrev.com/ee45633faa3fae0320db4b630ec24221e930478e/chrome/browser/profiles/profile_impl_io_data.cc
,
Aug 1 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 29 2016