New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621599 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Sign in to add a comment

[W3C auto-import] Meta-bug: Automatically import w3c tests.

Project Member Reported by qyears...@chromium.org, Jun 20 2016

Issue description

Currently, w3c tests are updated manually by running Tools/Scripts/update-w3c-deps, then handling new failures in a number of ways.

In general, we'd like to keep Chromium's copy of the w3c tests up-to-date, so we want to implement an automatic process for doing this.

Relevant discussion, started by tkent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/iMQwsUiW0xM

A brainstorming doc: https://docs.google.com/document/d/1r9iF5SyQxYATH9DEf4Dsq5dV6aZnsdo_hPx2XrV0QlI/edit
 
Components: Blink>Infra
 Issue 625253  has been merged into this issue.
Blockedon: 625258 625252 625254

Comment 5 by dcampb@google.com, Jul 8 2016

Blockedon: 626529
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83f3951c0bb76227abc80faeaae2b884c18d193a

commit 83f3951c0bb76227abc80faeaae2b884c18d193a
Author: raikiri <raikiri@google.com>
Date: Fri Jul 08 02:15:36 2016

Add --auto-update flag which uploads committed CL and initiates the CQ

The --auto-update flag is meant to provide the functionality of uploading a CL and initiating CQ to a bot for the automatic importing of w3c tests.

BUG= 621599 

Review-Url: https://codereview.chromium.org/2107993002
Cr-Commit-Position: refs/heads/master@{#404309}

[modify] https://crrev.com/83f3951c0bb76227abc80faeaae2b884c18d193a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
[add] https://crrev.com/83f3951c0bb76227abc80faeaae2b884c18d193a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

Comment 7 by dcampb@google.com, Jul 18 2016

Blockedon: 629275

Comment 8 by dcampb@google.com, Jul 29 2016

Blockedon: 632780

Comment 9 by dcampb@google.com, Aug 10 2016

Blockedon: 636379
Cc: -raikiri@google.com -dcampb@google.com
Owner: qyears...@chromium.org
Status: Assigned (was: Available)
Note, most of the updates for this issue have been happening in  bug 629275 , but these are really the same issue. Will dupe that issue into this one.
Cc: dpranke@chromium.org qyears...@chromium.org
 Issue 629275  has been merged into this issue.
Update: w3c-test-autoroller has had its first successful commit: http://crrev.com/2332303002
Woohoo!
Blockedon: 647395
Issue 647726 has been merged into this issue.
Blockedon: 649010
Blockedon: 649464
Blocking: 649691
Blocking: -649691
Blockedon: 649691
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6212078b2160aac8c8310d2a484a499d5b8a6c86

commit 6212078b2160aac8c8310d2a484a499d5b8a6c86
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Oct 06 23:21:06 2016

In update-w3c-test-expectations, stage all new files before committing.

Currently, w3c-test-autoroller is blocked on importing
because new baseline files are not added and committed
before uploading.  Example of a build where this happens:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7732.

Purpose: This CL would unblock this issue on w3c-test-autoroller.

This would be unnecessary (and could be reverted) if either of
http://crrev.com/2397573002 or http://crrev.com/2396433004 is committed.

BUG= 621599 

Review-Url: https://codereview.chromium.org/2394913002
Cr-Commit-Position: refs/heads/master@{#423728}

[modify] https://crrev.com/6212078b2160aac8c8310d2a484a499d5b8a6c86/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
[modify] https://crrev.com/6212078b2160aac8c8310d2a484a499d5b8a6c86/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py

Blockedon: 654030
Blockedon: 656171
Blockedon: 655201
Blocking: 657117
Blockedon: 659180
Project Member

Comment 27 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6212078b2160aac8c8310d2a484a499d5b8a6c86

commit 6212078b2160aac8c8310d2a484a499d5b8a6c86
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Oct 06 23:21:06 2016

In update-w3c-test-expectations, stage all new files before committing.

Currently, w3c-test-autoroller is blocked on importing
because new baseline files are not added and committed
before uploading.  Example of a build where this happens:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7732.

Purpose: This CL would unblock this issue on w3c-test-autoroller.

This would be unnecessary (and could be reverted) if either of
http://crrev.com/2397573002 or http://crrev.com/2396433004 is committed.

BUG= 621599 

Review-Url: https://codereview.chromium.org/2394913002
Cr-Commit-Position: refs/heads/master@{#423728}

[modify] https://crrev.com/6212078b2160aac8c8310d2a484a499d5b8a6c86/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
[modify] https://crrev.com/6212078b2160aac8c8310d2a484a499d5b8a6c86/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py

Blockedon: 660888

Comment 29 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Blockedon: 662570
Blockedon: 662929
Blockedon: 664663
Project Member

Comment 33 by bugdroid1@chromium.org, Nov 13 2016

Blockedon: 666540
Project Member

Comment 35 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db88ab19535414c5055426dc1a2658651f5ae80b

commit db88ab19535414c5055426dc1a2658651f5ae80b
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Nov 30 17:56:03 2016

In test_parser, skip files with non-ascii tags, and emit an error.

I believe this would make the w3c test auto-importer skip some files that have non-ascii characters in tags.

See latest failure: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7805. In that build, the importer is failing when looking at some file in web-platform-tests/domxpath/ which has non-ascii characters in tags.

BUG= 621599 

Review-Url: https://codereview.chromium.org/2523473004
Cr-Commit-Position: refs/heads/master@{#435326}

[modify] https://crrev.com/db88ab19535414c5055426dc1a2658651f5ae80b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py
[modify] https://crrev.com/db88ab19535414c5055426dc1a2658651f5ae80b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser_unittest.py

Summary: [W3C auto-import] Meta-bug: Automatically import w3c tests. (was: Automatically import w3c tests.)
Components: Blink>Infra>Predictability
Components: -Blink>Infra
Status: Fixed (was: Assigned)
Bug update: The bulk of this work was completed some time ago, and we are getting successful auto-imports (sometimes).

All specific current issues are being tracked in specific issues: https://bugs.chromium.org/p/chromium/issues/list?can=2&q=component%3ABlink>Infra>Predictability+import

Blockedon: -655201
Blockedon: -662570
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment