New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621575 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 354261
issue 621677



Sign in to add a comment

pack_policy_templates GYP target hasn't been ported to GN

Project Member Reported by dpranke@chromium.org, Jun 20 2016

Issue description

It looks like there's a 'policy_templates.zip' file that is bundled up as part of the official builds, but it hasn't been ported to GN yet.

Neither brettw@ nor I know what this file is used for, if it's still needed, or if it's correct. We need to figure out if it needs to be ported.
 

Comment 1 by mmoss@chromium.org, Jun 20 2016

This zip is still archived with the official builds, but that handling dates back to at least https://chromium.googlesource.com/chromium/tools/build/+/c6b00faf9c21f89cf774b31c7b4eaf19373af77c (and now via FILES.cfg), but I have no idea if it's actually used for anything.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d5b7069c8376c83fb8b3d35b0df49979592bb2a

commit 1d5b7069c8376c83fb8b3d35b0df49979592bb2a
Author: dpranke <dpranke@chromium.org>
Date: Mon Jun 20 21:09:04 2016

Flip Google Chrome Win builder to GN.

And add the missing //:chrome_official_builder_no_unittests target
that caused the prior flip to be reverted :).

R=brettw@chromium.org
BUG= 605318 ,  621575 

Review-Url: https://codereview.chromium.org/2082683003
Cr-Commit-Position: refs/heads/master@{#400780}

[modify] https://crrev.com/1d5b7069c8376c83fb8b3d35b0df49979592bb2a/BUILD.gn
[modify] https://crrev.com/1d5b7069c8376c83fb8b3d35b0df49979592bb2a/tools/mb/mb_config.pyl

Blocking: 621677
Labels: -Pri-1 M-53 Pri-2
Owner: zmin@chromium.org
Status: Assigned (was: Untriaged)
@zmin - I'm assuming we need this to be done as part of shipping GN, which we're targeting for M-53. Please let me know if you think you won't be able to get this done by then.
Blocking: 354261
This is file is certainly needed. It is being uploaded for each new release of Chrome here https://www.chromium.org/administrators/policy-templates for admins to be able to update their Windows GPO, Mac PLists or on linux as a template for the policy files. 

There is an automated process which transports this file for each release but I will have to dig up who has done this. However if we can port the creation of this file 100% to GN than this process whatever it is should happily continue to work.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6211e7d67d57db54d8c5b9a56b9be6de99618ef4

commit 6211e7d67d57db54d8c5b9a56b9be6de99618ef4
Author: zmin <zmin@chromium.org>
Date: Thu Jun 23 01:19:29 2016

Adds gn config for policy_templates.zip

BUG= 621575 

Review-Url: https://codereview.chromium.org/2083903005
Cr-Commit-Position: refs/heads/master@{#401497}

[modify] https://crrev.com/6211e7d67d57db54d8c5b9a56b9be6de99618ef4/BUILD.gn
[modify] https://crrev.com/6211e7d67d57db54d8c5b9a56b9be6de99618ef4/components/policy/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment