New issue
Advanced search Search tips

Issue 621574 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mash: Move accessibility_types.h to //ash and namespace ash

Project Member Reported by jamescook@chromium.org, Jun 20 2016

Issue description

Right now it lives in //ui/chromeos/. However, it's only used in //ash. There are also many places in //ash and //chrome/browser that use it without #if defined(OS_CHROMEOS) guards.

Rather than wrapping a bunch of a11y code in #ifdefs I think this file should just move to //ash and be put in namespace ash.

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2741744f732caf973d062a4bf3d5b53e6d621a25

commit 2741744f732caf973d062a4bf3d5b53e6d621a25
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 20 21:37:05 2016

Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG= 619636 , 621574 
TEST=ash_unittests
TBR=atwilson@chromium.org for mechanical change to //chrome/browser/policy

Review-Url: https://codereview.chromium.org/2074913005
Cr-Commit-Position: refs/heads/master@{#400791}

[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/ash.gyp
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/ash_touch_exploration_manager_chromeos.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/common/accessibility_delegate.h
[rename] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/common/accessibility_types.h
[add] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/common/system/accessibility_observer.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/common/system/tray/wm_system_tray_notifier.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/keyboard/keyboard_ui.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/magnifier/magnification_controller_unittest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/shell.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/tray/tray_details_view_unittest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/tray_accessibility.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/tray_accessibility.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/accessibility/magnification_manager_unittest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ui/chromeos/BUILD.gn
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ui/chromeos/ui_chromeos.gyp

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e

commit a7f8dabce6434cde68505212a2d8b2ef6e5dda7e
Author: jamescook <jamescook@chromium.org>
Date: Tue Jun 21 01:44:03 2016

mash: Move accessibility_types.h from ui namespace to ash namespace

It used to live in the ui namespace but the file moved to //ash.

* Find-and-replace changes across //ash and //chrome/browser
* Fix some include-what-you-use violations

BUG= 621574 
TEST=compiles, ash_unittests
TBR=stevenjb@chromium.org for mechanical changes in //chrome/browser/chromeos
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2078393005
Cr-Commit-Position: refs/heads/master@{#400872}

[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/accelerators/spoken_feedback_toggler.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/ash_touch_exploration_manager_chromeos.h
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/common/accessibility_delegate.h
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/common/accessibility_types.h
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/common/default_accessibility_delegate.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/common/default_accessibility_delegate.h
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/common/system/accessibility_observer.h
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/common/system/tray/wm_system_tray_notifier.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/keyboard/keyboard_ui.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/magnifier/magnification_controller_unittest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/system/tray_accessibility.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/system/tray_accessibility.h
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/accessibility/magnification_manager.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/accessibility/magnification_manager.h
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/accessibility/magnification_manager_unittest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e/chrome/browser/ui/webui/options/browser_options_handler.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Bulk verified
Components: -MUS Internals>Services>WindowService

Sign in to add a comment