New issue
Advanced search Search tips

Issue 621558 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

mariadb: failed to build with new cmake_utils.eclass

Project Member Reported by yunlian@chromium.org, Jun 20 2016

Issue description

With upstream cmake_utils.eclass, 
emerge-guado_moblab mariadb

I got
make[2]: Entering directory '/build/guado_moblab/tmp/portage/dev-db/mariadb-5.5.32-r6/work/mariadb-5.5.32_build'
make[2]: *** No rule to make target '/build/guado_moblab/tmp/portage/dev-db/mariadb-5.5.32-r6/work/mysql/extra/comp_err', needed by 'include/mysqld_error.h.tmp'.  Stop.

This is because it would not build comp_err when cros compiling.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/af1fc004ef11d8823d88484a60cf2c2aedfc2480

commit af1fc004ef11d8823d88484a60cf2c2aedfc2480
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Jun 22 04:42:21 2016

mariadb: work around cros copmiliation error.

New cmake_utils.eclass detects the build of mariadb on the guado-moblab
board is cros build. It disables the build of some binary that runs on the host,
this causes the build failure. This CL workarounds it by letting cros
compiler build binary that runs on the host. This is the old/working
behavior.

BUG=chromium:621558
TEST=ebuild-guado-moblab mariadb passes on upstream cmake-utils.eclass

Change-Id: I6cc7ddf36bb7fa9762627a8b1a2ed34db27206b4
Reviewed-on: https://chromium-review.googlesource.com/354692
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/af1fc004ef11d8823d88484a60cf2c2aedfc2480/dev-db/mariadb/mariadb-5.5.32-r7.ebuild
[add] https://crrev.com/af1fc004ef11d8823d88484a60cf2c2aedfc2480/dev-db/mariadb/files/mariadb-5.5.32-workaround-cros-build.patch
[modify] https://crrev.com/af1fc004ef11d8823d88484a60cf2c2aedfc2480/dev-db/mariadb/mariadb-5.5.32.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/1957d62c74d0bec1dc5ae27cc6af229c2024a953

commit 1957d62c74d0bec1dc5ae27cc6af229c2024a953
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Mon Jun 13 16:01:01 2016

Reland "portage-stable: update cmake-utils.eclass."

The fix for mariodb is at CL:354090. Once that gets in, We can try
this again.

This reverts commit 9f50710035fd14bd00d80f921e78d5d8f312e2a8.

BUG=chromium:621558
TEST=cbuildbot guado_moblab-release

Change-Id: Ic2bda925e414f7f819c951f02c6e548bbf8238ed
Reviewed-on: https://chromium-review.googlesource.com/351961
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1957d62c74d0bec1dc5ae27cc6af229c2024a953/eclass/cmake-utils.eclass

Components: Build

Sign in to add a comment