See http://www.stroustrup.com/C++11FAQ.html#enum to see why enum class is preferred over traditional enums.
Can I work on this?
Yes. I don't have any plans for it yet. I don't even have broadband connection by now.
Barring a compiler error with an UMA macro, this is almost ready to be submitted for review.
Sent for review.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87b7a3fcc1bce355eae717c60c35309dcb0b8353 commit 87b7a3fcc1bce355eae717c60c35309dcb0b8353 Author: tfarina <tfarina@chromium.org> Date: Fri Oct 21 01:35:24 2016 chrome: change ProfileErrorType enum into an enum class See http://www.stroustrup.com/C++11FAQ.html#enum to see why enum class is preferred over traditional enums. BUG= 621555 R=thestig@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2438433006 Cr-Commit-Position: refs/heads/master@{#426682} [modify] https://crrev.com/87b7a3fcc1bce355eae717c60c35309dcb0b8353/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/87b7a3fcc1bce355eae717c60c35309dcb0b8353/chrome/browser/history/chrome_history_client.cc [modify] https://crrev.com/87b7a3fcc1bce355eae717c60c35309dcb0b8353/chrome/browser/prefs/chrome_pref_service_factory.cc [modify] https://crrev.com/87b7a3fcc1bce355eae717c60c35309dcb0b8353/chrome/browser/ui/profile_error_dialog.cc [modify] https://crrev.com/87b7a3fcc1bce355eae717c60c35309dcb0b8353/chrome/browser/ui/profile_error_dialog.h [modify] https://crrev.com/87b7a3fcc1bce355eae717c60c35309dcb0b8353/chrome/browser/web_data_service_factory.cc
Comment 1 by tfarina@chromium.org
, Oct 19 2016