New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621551 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 595010



Sign in to add a comment

Remove the |opaque_background_| Layer from ShelfWidget

Project Member Reported by bruthig@chromium.org, Jun 20 2016

Issue description

The Shelf and Dock currently use an opaque Layer to paint the background.  It is unclear if the Layer is actually necessary, but if not, it should be removed.
 
Cc: varkha@chromium.org est...@chromium.org
Components: UI>Shell>Shelf UI>Shell>StatusArea
Labels: Proj-MaterialDesign-CrOS
See the corresponding TODO in ash/common/shelf/shelf_widget.cc.
Owner: bruthig@chromium.org
Status: Assigned (was: Available)
Consider that docked windows are going away so this part of work could become redundant.
Status: Started (was: Assigned)
Blocking: 595010
Labels: -Pri-3 M-58 Pri-2
Labels: Hotlist-CodeHealth
Ben is this still started (m-58) or should we punt to 59 / remove milestone label?
Labels: -Pri-2 -M-58 Pri-3
Status: Available (was: Started)
This was originally filed under the assumption that the |opaque_layer_| was expensive, however it is a SOLID_COLOR which is not terribly expensive.

So I am downgrading this priority, if we choose to not proceed with the work a CL to remove the TODO's in the code should at least be submitted.
Is DockedBackgroundWidget still a thing or has it been removed?
It appears to be a thing still.
#11, will probably no longer be there with https://codereview.chromium.org/2700523004/
Owner: afakhry@chromium.org
Status: Assigned (was: Available)
Re-assigning to afakhry@ re #11.
Owner: bruthig@chromium.org
Sorry, miscommunication, I will take this one back.

I'm planning to mark this one as a WontFix because the |opaque_background_| layer is a SOLID_COLOR layer which is cheaper than originally thought.  The only reason I haven't closed the issue is because there are some TODO's in the code that should be cleaned up.
Summary: Remove the |opaque_background_| Layer from ShelfWidget (was: Remove the |opaque_background_| Layer from ShelfWidget and DockedBackgroundWidget)
DockedBackgroundWidget has since been removed, updating title to reflect that.
Status: Started (was: Assigned)
Code TODO is being removed here: https://codereview.chromium.org/2887463003/

Will mark this as a WontFix once that lands...
Project Member

Comment 17 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce7c55b8355104296e2c369333b591ad9e195331

commit ce7c55b8355104296e2c369333b591ad9e195331
Author: bruthig <bruthig@chromium.org>
Date: Mon May 15 21:47:21 2017

[ash-md] Removed unwanted TODO from ShelfWidget::DelegateView::opaque_background_

Removinga stale TODO after some learning the |opaque_background_| is a good
implementation.

BUG= 621551 

Review-Url: https://codereview.chromium.org/2887463003
Cr-Commit-Position: refs/heads/master@{#471914}

[modify] https://crrev.com/ce7c55b8355104296e2c369333b591ad9e195331/ash/shelf/shelf_widget.cc

Status: WontFix (was: Started)
Status: Fixed (was: WontFix)
I assume you meant Fixed?
wontfix seems appropriate given the title of the bug
Labels: VerifyIn-61

Comment 22 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment