Remove the |opaque_background_| Layer from ShelfWidget |
|||||||||||||||
Issue descriptionThe Shelf and Dock currently use an opaque Layer to paint the background. It is unclear if the Layer is actually necessary, but if not, it should be removed.
,
Feb 2 2017
,
Feb 2 2017
Consider that docked windows are going away so this part of work could become redundant.
,
Feb 6 2017
,
Feb 6 2017
,
Feb 7 2017
,
Feb 7 2017
,
Mar 7 2017
Ben is this still started (m-58) or should we punt to 59 / remove milestone label?
,
Mar 7 2017
This was originally filed under the assumption that the |opaque_layer_| was expensive, however it is a SOLID_COLOR which is not terribly expensive. So I am downgrading this priority, if we choose to not proceed with the work a CL to remove the TODO's in the code should at least be submitted.
,
Mar 8 2017
Is DockedBackgroundWidget still a thing or has it been removed?
,
Mar 8 2017
It appears to be a thing still.
,
Mar 8 2017
#11, will probably no longer be there with https://codereview.chromium.org/2700523004/
,
Mar 14 2017
Re-assigning to afakhry@ re #11.
,
Mar 14 2017
Sorry, miscommunication, I will take this one back. I'm planning to mark this one as a WontFix because the |opaque_background_| layer is a SOLID_COLOR layer which is cheaper than originally thought. The only reason I haven't closed the issue is because there are some TODO's in the code that should be cleaned up.
,
May 15 2017
DockedBackgroundWidget has since been removed, updating title to reflect that.
,
May 15 2017
Code TODO is being removed here: https://codereview.chromium.org/2887463003/ Will mark this as a WontFix once that lands...
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce7c55b8355104296e2c369333b591ad9e195331 commit ce7c55b8355104296e2c369333b591ad9e195331 Author: bruthig <bruthig@chromium.org> Date: Mon May 15 21:47:21 2017 [ash-md] Removed unwanted TODO from ShelfWidget::DelegateView::opaque_background_ Removinga stale TODO after some learning the |opaque_background_| is a good implementation. BUG= 621551 Review-Url: https://codereview.chromium.org/2887463003 Cr-Commit-Position: refs/heads/master@{#471914} [modify] https://crrev.com/ce7c55b8355104296e2c369333b591ad9e195331/ash/shelf/shelf_widget.cc
,
May 15 2017
,
May 24 2017
I assume you meant Fixed?
,
May 24 2017
wontfix seems appropriate given the title of the bug
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by tdander...@chromium.org
, Feb 2 2017Components: UI>Shell>Shelf UI>Shell>StatusArea
Labels: Proj-MaterialDesign-CrOS