New issue
Advanced search Search tips

Issue 621550 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in v8::internal::StackTraceFrameIterator::Advance

Project Member Reported by ClusterFuzz, Jun 20 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6149710461272064

Fuzzer: v8_builtins_generator
Job Type: windows_asan_d8
Platform Id: windows

Crash Type: UNKNOWN READ
Crash Address: 0xffffffff
Crash State:
  v8::internal::StackTraceFrameIterator::Advance
  v8::internal::StackTraceFrameIterator::StackTraceFrameIterator
  v8::internal::Isolate::ComputeLocation
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_asan_d8&range=400574:400576

Minimized Testcase (0.15 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv97Mndjt2nJYmbAg1yL_G811H9H-kB-ylTOVVUX48KjA7gkchy8A_Uog3uAwm1g3dNnRopwC4eg8thKzxToRBTibq8cvVMjgNcUjImGiQUJiZjFi5352xU1VLGwT1bLx3P3NI8RdvS-hZ15zjz6M3z2j8MQDyQ?testcase_id=6149710461272064
 v7 = new URIError(); 
 v13 = new Int32Array(); 
URIError.prototype.__defineGetter__("name", function() { 
return v7;
})
 v75 = Math.min(v13, v13, v7); 


Filer: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by mmoroz@chromium.org, Jun 20 2016

Cc: mmoroz@chromium.org
Components: Blink>JavaScript>Runtime
Labels: Pri-1
ishell@ and mstarzinger@, could you please help to triage this?

Comment 2 by est...@chromium.org, Jun 20 2016

Labels: M-53

Comment 3 by ishell@chromium.org, Jun 20 2016

Owner: ishell@chromium.org
Status: Assigned (was: Available)

Comment 4 by ishell@chromium.org, Jun 21 2016

Owner: jgruber@chromium.org
Same as  issue 621431  but here it is the StackTraceFrameIterator::IsValidFrame() who queries a JSFunction from a BUILTIN frame.
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 21 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6bd37e3f20651cc4ff780e09518ae2a408b509dc

commit 6bd37e3f20651cc4ff780e09518ae2a408b509dc
Author: jgruber <jgruber@chromium.org>
Date: Wed Jun 22 09:18:29 2016

[builtins] Fix clobbered reg in Math.{Max,Min}

edi is expected to contain the JS function. Ensure that it is not
overwritten.

BUG= chromium:621431 , chromium:621550 , chromium:621217 
R=bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/2085043004
Cr-Commit-Position: refs/heads/master@{#37173}

[modify] https://crrev.com/6bd37e3f20651cc4ff780e09518ae2a408b509dc/src/ia32/builtins-ia32.cc

Status: Fixed (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 22 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 9 by ClusterFuzz, Jun 22 2016

Labels: Merge-NA
Project Member

Comment 10 by ClusterFuzz, Jun 23 2016

ClusterFuzz has detected this testcase as flaky and is unable to reproduce it in the original crash revision. Skipping fixed testing check and marking it as potentially fixed.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6149710461272064

Fuzzer: v8_builtins_generator
Job Type: windows_asan_d8
Platform Id: windows

Crash Type: UNKNOWN READ
Crash Address: 0xffffffff
Crash State:
  v8::internal::StackTraceFrameIterator::Advance
  v8::internal::StackTraceFrameIterator::StackTraceFrameIterator
  v8::internal::Isolate::ComputeLocation
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_asan_d8&range=400574:400576

Minimized Testcase (0.15 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv97Mndjt2nJYmbAg1yL_G811H9H-kB-ylTOVVUX48KjA7gkchy8A_Uog3uAwm1g3dNnRopwC4eg8thKzxToRBTibq8cvVMjgNcUjImGiQUJiZjFi5352xU1VLGwT1bLx3P3NI8RdvS-hZ15zjz6M3z2j8MQDyQ?testcase_id=6149710461272064
 v7 = new URIError(); 
 v13 = new Int32Array(); 
URIError.prototype.__defineGetter__("name", function() { 
return v7;
})
 v75 = Math.min(v13, v13, v7); 


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: -ReleaseBlock-Beta -ClusterFuzz -merge-na Clusterfuzz Merge-na
Fix already in M53, removing ReleaseBlock-Beta.
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 28 2016

Labels: -Restrict-View-SecurityNotify
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 2 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic

Sign in to add a comment