New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621528 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 621526



Sign in to add a comment

bluetooth: Move BluetoothAdapterFactoryWrapper into device/bluetooth

Project Member Reported by ortuno@chromium.org, Jun 20 2016

Issue description

Moving BluetoothAdapterFactoryWrapper avoids the need to access a member from RenderProcessHostImpl

Adding GetBluetoothScanDuration to the embedder interfaces allows Clients to set their own scan duration.

WIP: http://crrev.com/2059543002
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/189e95876f948145773b4a1151716eadb58ca1a0

commit 189e95876f948145773b4a1151716eadb58ca1a0
Author: ortuno <ortuno@chromium.org>
Date: Fri Jul 08 20:06:45 2016

bluetooth: Move FactoryWrapper to device and expose a function for testing in chooser controller

Moving BluetoothAdapterFactoryWrapper avoids the need to access a member from
RenderProcessHostImpl, which avoids casting from RenderProcessHost to
RenderProcessHostImpl.

The scan duration is a web bluetooth concept and therefore should not be part of
the FactoryWrapper in device. To that extent we expose a static function in
BluetoothDeviceChooserController that allows tests to set a scan duration of 0.

BUG= 621528 

Review-Url: https://codereview.chromium.org/2059543002
Cr-Commit-Position: refs/heads/master@{#404472}

[delete] https://crrev.com/fd1cb64d5070bd041e86434e91a8cca796414367/content/browser/bluetooth/bluetooth_adapter_factory_wrapper.cc
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/browser/bluetooth/bluetooth_device_chooser_controller.h
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/content_browser.gypi
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/public/test/layouttest_support.h
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/shell/browser/layout_test/layout_test_bluetooth_fake_adapter_setter_impl.cc
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/shell/browser/layout_test/layout_test_bluetooth_fake_adapter_setter_impl.h
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/content/test/layouttest_support.cc
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/device/bluetooth/BUILD.gn
[modify] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/device/bluetooth/bluetooth.gyp
[add] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/device/bluetooth/bluetooth_adapter_factory_wrapper.cc
[rename] https://crrev.com/189e95876f948145773b4a1151716eadb58ca1a0/device/bluetooth/bluetooth_adapter_factory_wrapper.h

Status: Fixed (was: Started)

Sign in to add a comment