New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621515 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

LayoutTest failures when --harmony-async-await is disabled

Reported by caitpott...@gmail.com, Jun 20 2016

Issue description

Tracking bug for tests which fail without --js-flags=--harmony-async-await

 
Labels: Needs-Feedback
Can you give us more context and details about this? What tests are failing?
just a tracking bug for a blink TestExpectations line for layout tests which depend on --js-flags=--harmony-async-await

Once it ships, bug will be fixed
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 21 2016

Labels: -Needs-Feedback Needs-Review
Owner: spqc...@chromium.org
Thank you for providing more feedback. Adding requester "spqchan@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Blink
Owner: ----

Comment 6 by pdr@chromium.org, Jun 24 2016

Components: -Blink Blink>JavaScript
Labels: -Needs-Review -OS-Mac OS-All
Just triaging this off the catchall Blink label. Async/await is a javascript feature.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/459aa22b3344f3f8097e05cf57cc2631ec0ab4b1

commit 459aa22b3344f3f8097e05cf57cc2631ec0ab4b1
Author: caitpotter88 <caitpotter88@gmail.com>
Date: Fri Jun 24 23:46:47 2016

[LayoutTests] Split up inspector/sources/debugger-async/async-await/async-callstack-async-await.html

Split up test in order to minimize Timeout flakes

R=hbos@chromium.org, dgozman@chromium.org, littledan@chromium.org
BUG= 622696 ,  621515 

Review-Url: https://codereview.chromium.org/2099723002
Cr-Commit-Position: refs/heads/master@{#402015}

[modify] https://crrev.com/459aa22b3344f3f8097e05cf57cc2631ec0ab4b1/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/d63137acbe0976b05cbda68db72b466755310f5a/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await-expected.txt
[add] https://crrev.com/459aa22b3344f3f8097e05cf57cc2631ec0ab4b1/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await1-expected.txt
[rename] https://crrev.com/459aa22b3344f3f8097e05cf57cc2631ec0ab4b1/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await1.html
[add] https://crrev.com/459aa22b3344f3f8097e05cf57cc2631ec0ab4b1/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await2-expected.txt
[copy] https://crrev.com/459aa22b3344f3f8097e05cf57cc2631ec0ab4b1/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await2.html

Components: -Blink>JavaScript Blink>JavaScript>Language
Owner: dehrenberg@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: caitpott...@gmail.com
Owner: littledan@chromium.org
Are there any remaining failures?
See the issue description, this is just tracking the TestExpectations that these tests are skipped when the feature is not enabled.

When the flag is enabled, the tests can be unskipped, the virtual test suite can probably be removed, and the "bug" will be fixed.
s/flag is enabled/feature is shipped/
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c21f0eed0a07d8542838f4d5aaeb6d7fa0b2c339

commit c21f0eed0a07d8542838f4d5aaeb6d7fa0b2c339
Author: lukasza <lukasza@chromium.org>
Date: Tue Aug 23 18:12:20 2016

Skip virtual equivalent of async-callstack-async-await*.html layout tests.

Non-virtual async-callstack-async-await*.html tests have been disabled
in r409884, but the tests have been flakily running and timing out in
the virtual test suites:

- Site Isolation Win:
  https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/15853

- WebKit Mac10.11 (dbg):
  https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fasyncawait%2Finspector%2Fsources%2Fdebugger-async%2Fasync-await%2Fasync-callstack-async-await2.html

Based, on the above, this CL is broadening the test expectations for
virtual/asyncawait/.../async-callstack-async-await[23].html so that:

- They cover non-Debug builds (since Site Isolation Win tests Release build)

- They cover all platforms (since these tests are also flaky on Mac10.11)

BUG= 636835 ,  621515 
NOTRY=true

Review-Url: https://codereview.chromium.org/2276583002
Cr-Commit-Position: refs/heads/master@{#413786}

[modify] https://crrev.com/c21f0eed0a07d8542838f4d5aaeb6d7fa0b2c339/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eabc22ef76859401193b8ff870b5a4b429661f9

commit 4eabc22ef76859401193b8ff870b5a4b429661f9
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Aug 23 19:17:31 2016

[DevTools] Masrk virtual/asyncawait/inspector as slow

Mark virtual/asyncawait/inspector/sources/debugger-async/ as SLOW.
I'll mark it as timeout if it won't help.

BUG= 636835 ,  621515 
NOTRY=true
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2275643002
Cr-Commit-Position: refs/heads/master@{#413811}

[modify] https://crrev.com/4eabc22ef76859401193b8ff870b5a4b429661f9/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/4eabc22ef76859401193b8ff870b5a4b429661f9/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7534dfcb230327db0a378dd57413d8886ac924d3

commit 7534dfcb230327db0a378dd57413d8886ac924d3
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Sat Oct 22 03:03:58 2016

[DevTools] Better label for async function call stacks

Async call stack with async function always contains (async function) label and async function as top frame for following stack. We can merge label with this frame for better user experience.

R=dgozman@chromium.org,littledan@chromium.org
BUG= 654018 , 621515 

Review-Url: https://chromiumcodereview.appspot.com/2384533002
Cr-Commit-Position: refs/heads/master@{#426960}

[modify] https://crrev.com/7534dfcb230327db0a378dd57413d8886ac924d3/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/7534dfcb230327db0a378dd57413d8886ac924d3/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7534dfcb230327db0a378dd57413d8886ac924d3/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/7534dfcb230327db0a378dd57413d8886ac924d3/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await1-expected.txt
[modify] https://crrev.com/7534dfcb230327db0a378dd57413d8886ac924d3/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await2-expected.txt
[modify] https://crrev.com/7534dfcb230327db0a378dd57413d8886ac924d3/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await3-expected.txt
[add] https://crrev.com/7534dfcb230327db0a378dd57413d8886ac924d3/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-async-function-expected.txt
[add] https://crrev.com/7534dfcb230327db0a378dd57413d8886ac924d3/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-async-function.html
[delete] https://crrev.com/87303d73f481bfa8acb3508180070ca70cecd4ca/third_party/WebKit/LayoutTests/virtual/asyncawait/README.txt
[delete] https://crrev.com/87303d73f481bfa8acb3508180070ca70cecd4ca/third_party/WebKit/LayoutTests/virtual/asyncawait/inspector/sources/debugger-async/async-await/README.txt
[modify] https://crrev.com/7534dfcb230327db0a378dd57413d8886ac924d3/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/7534dfcb230327db0a378dd57413d8886ac924d3/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Cc: adamk@chromium.org
Is this done?
Status: Fixed (was: Assigned)
Marking as fixed, as the flag is long-gone and no test expectations files reference this bug.

Sign in to add a comment