DrMemory errors for ICOImageDecoderTests.parseAndDecodeByteByByte |
|||
Issue descriptionStarted happening after https://codereview.chromium.org/2065423003/ ) First failing build with this change: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/5095 Sample error: ICOImageDecoderTests.parseAndDecodeByteByByte: c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83): error: Expected: (frameCount) <= (decoder->frameCount()), actual: 2 vs 0 c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83): error: Expected: (frameCount) <= (decoder->frameCount()), actual: 3 vs 0 c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83): error: Expected: (frameCount) <= (decoder->frameCount()), actual: 1 vs 0 c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83): error: Expected: (frameCount) <= (decoder->frameCount()), actual: 1 vs 0
,
Jun 20 2016
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e621d9fc8a99383a04f5249f75f61a43cab2198 commit 4e621d9fc8a99383a04f5249f75f61a43cab2198 Author: aleksandar.stojiljkovic <aleksandar.stojiljkovic@intel.com> Date: Mon Jun 27 14:09:25 2016 ICOImageDecoder: fix decodeFrameCount when there is no enough data to parse directory entries. Initializing struct members helps exposing the issue - otherwise, it was reproducible always only with placement new when buffer was zeroed before it. Re-enable DrMemory test for ICOImageDecoderTests.parseAndDecodeByteByByte. BUG= 621488 Review-Url: https://codereview.chromium.org/2081013002 Cr-Commit-Position: refs/heads/master@{#402168} [modify] https://crrev.com/4e621d9fc8a99383a04f5249f75f61a43cab2198/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp [modify] https://crrev.com/4e621d9fc8a99383a04f5249f75f61a43cab2198/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h [modify] https://crrev.com/4e621d9fc8a99383a04f5249f75f61a43cab2198/tools/valgrind/gtest_exclude/blink_platform_unittests.gtest_win32.txt
,
Jul 18 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 20 2016