Regression : Unable to add url in 'Show Home button' in chrome://md-settings page
Reported by
mni...@etouch.net,
Jun 20 2016
|
|||||||||||||||||||
Issue descriptionChrome Version: 53.0.2773.0 Revision ced2fcee2c85702055d028f4e3e48c5a75a7e41c-refs/heads/master@{#400610} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4) What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://md-settings (2) Click on 'Show home button' checkbox and select 'Other' radio button and add url,observe Actual : Unable to add url in 'Show Home button' since focus is lost while adding url Expected : Should be able to write url in 'Show Home button' and focus should not be lost. This is a regression issue, broken in 'M-53', below is manual bisect and Narrow bisect info : Good Build: 53.0.2748.0 Bad Build: 53.0.2749.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/1f192ea58ce279fd382efd3a362f8afff9f79cc1..a2e6a0c352d0f2bd62a245d26abbad617e06cad3?pretty=fuller&n=50 Suspecting: r395822 ? from Narrow bisect @yoichio : Could you please help to reassign if your change is not the cause for this change.
,
Jun 27 2016
@yoichio: Hey, would you mind providing an update on the above issue? Appreciate the help. Thank you!
,
Jun 28 2016
I didn't reproduce on 53.2781.0 canary on win.
,
Jun 28 2016
With response to comment #3 : Rechecked the above issue on latest canary chrome version : 53.0.2781.0 on Win 7 OS and the issue is reproducible.Please refer the attached video for reference
,
Jun 28 2016
I did't reproduce yet. Plus, -webkit-user-select:text is set to the element. Thus my change doesn't relate.
,
Jul 5 2016
Re-bisected and found the same regression range as in C#0. With yoichio@'s change out from the suspected list, tsergeant@: Could you please confirm if this could be related to https://codereview.chromium.org/1984963002. Please help in finding an appropriate owner if the above change is unrelated. Thank you!
,
Jul 5 2016
Looks like this bug was caused by my Polymer roll. The exact problem is very silly: The Polymer roll updated <paper-radio-group> to extend from IronMenubarBehavior, which adds keyboard shortcuts to focus different radio buttons. So, pressing 'n' while typing in a URL will focus the 'New Tab Page' radio button, and then pressing 'o' will focus the 'Other' radio button. Assigning to dschuyler@ to investigate further from the settings side.
,
Jul 6 2016
,
Jul 6 2016
Issue 621373 has been merged into this issue.
,
Jul 12 2016
dschuyler@: Could you please update the thread for this blocker issue.
,
Jul 18 2016
pinging again as this is marked as RBS and tagged for M53, dschuyler@ could you please check and update.
,
Jul 20 2016
MD settings is not going out in M53.
,
Jul 25 2016
,
Jul 26 2016
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ba8786cfbc72edbdb38e37bcc9b29d0ac0696ee commit 0ba8786cfbc72edbdb38e37bcc9b29d0ac0696ee Author: dschuyler <dschuyler@chromium.org> Date: Thu Jul 28 19:14:56 2016 [MD settings] propagate stopKeyboardEventPropagation to paper-input This CL passes stopKeyboardEventPropagation from settings-input to the underlying paper-input and then uses that property to keep the focus in the home page url setting. BUG= 621480 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2187713003 Cr-Commit-Position: refs/heads/master@{#408451} [modify] https://crrev.com/0ba8786cfbc72edbdb38e37bcc9b29d0ac0696ee/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/0ba8786cfbc72edbdb38e37bcc9b29d0ac0696ee/chrome/browser/resources/settings/controls/settings_input.html [modify] https://crrev.com/0ba8786cfbc72edbdb38e37bcc9b29d0ac0696ee/chrome/browser/resources/settings/controls/settings_input.js
,
Jul 28 2016
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by tkonch...@chromium.org
, Jun 20 2016