Issue 621467 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	est...@chromium.org
Closed:	Jun 2016
Cc:	nyerramilli@chromium.org pbomm...@chromium.org █ tkonch...@chromium.org est...@chromium.org sgabr...@chromium.org
Components:	UI>Browser>Downloads UI>Browser>Incognito
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows
Pri:	1
Type:	Bug-Regression
hasbisect M-53 ReleaseBlock-Stable

need to specify button text, outline and focus ring colors for incognito download shelf

Reported by vvishwak...@etouch.net, Jun 20 2016

Issue description

Version: 53.0.2773.0 (Official Build) ced2fcee2c85702055d028f4e3e48c5a75a7e41c-refs/heads/master@{#400610} (32/64-bit)
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
1) Launch chrome, open a New Incognito window and save any webpage.
2) In Downloads shelf at bottom observe the 'Show all' button.

'Show all' button is not visible in Downloads shelf.

'Show all' button should be visible in Downloads shelf.

This is a Regression issue broken in M-53, will soon update other info.

Comment 1 by vvishwak...@etouch.net, Jun 20 2016

Cc: pbomm...@chromium.org
Labels: hasbisect
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)

Manual bisect:
Good build: 53.0.2770.0 
Bad build: 53.0.2772.0 

Narrow bisect URL:
https://chromium.googlesource.com/chromium/src/+log/c4dd4ff0308ae28239a0a18d7374691fbb3ff1e8..f2eb108ab1e65962104bfde275743369b0e7665b?pretty=fuller&n=10000

Suspecting: r400511

Note: Issue is not seen on Linux and Mac OS.

	Incognito_downloads.jpg 60.7 KB View Download

Comment 2 by tkonch...@chromium.org, Jun 20 2016

Labels: ReleaseBlock-Stable

Adding RB label as this is a recent regression

Comment 3 by est...@chromium.org, Jun 20 2016

Cc: est...@chromium.org

 Issue 621482  has been merged into this issue.

Comment 4 by est...@chromium.org, Jun 20 2016

Cc: sgabr...@chromium.org
Labels: OS-Linux
Summary: need to specify button text, outline and focus ring colors for incognito download shelf (was: Regression: In Incognito mode, Show all button in Downloads shelf is not visible.)

Comment 5 by est...@chromium.org, Jun 21 2016

 Issue 622079  has been merged into this issue.

Comment 6 by est...@chromium.org, Jun 21 2016

Owner: sgabr...@chromium.org

Sebastien to provide incognito styling for this button. Assign back to me for implementation.

Comment 7 by est...@chromium.org, Jun 22 2016

similar problem when using custom themes

	dlshelf.png 527 KB View Download

Comment 8 by sgabr...@chromium.org, Jun 22 2016

Owner: est...@chromium.org

Updated the spec to include buttons on dark theme/incognito. 
See: https://drive.google.com/a/google.com/folderview?id=0B6x6iYCtKinERVJ6WjNCV21SSmM&usp=sharing

Spec name: SPEC-secondary-UI-01b-buttons-dark-theme.png

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdea3ac49bea89fb560dd555c5fc710b54fbc316

commit fdea3ac49bea89fb560dd555c5fc710b54fbc316
Author: estade <estade@chromium.org>
Date: Thu Jun 23 20:23:39 2016

MD - Fix coloring of buttons on DL shelf.

This fixes themes as well as incognito.

BUG= 621467 

Review-Url: https://codereview.chromium.org/2094553002
Cr-Commit-Position: refs/heads/master@{#401702}

[modify] https://crrev.com/fdea3ac49bea89fb560dd555c5fc710b54fbc316/chrome/browser/ui/views/download/download_item_view_md.cc
[modify] https://crrev.com/fdea3ac49bea89fb560dd555c5fc710b54fbc316/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/fdea3ac49bea89fb560dd555c5fc710b54fbc316/chrome/browser/ui/views/download/download_shelf_view.h
[modify] https://crrev.com/fdea3ac49bea89fb560dd555c5fc710b54fbc316/ui/native_theme/native_theme_dark_aura.cc
[modify] https://crrev.com/fdea3ac49bea89fb560dd555c5fc710b54fbc316/ui/views/controls/button/label_button.h
[modify] https://crrev.com/fdea3ac49bea89fb560dd555c5fc710b54fbc316/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/fdea3ac49bea89fb560dd555c5fc710b54fbc316/ui/views/controls/button/md_text_button.h

Comment 10 by est...@chromium.org, Jun 24 2016

Status: Fixed (was: Assigned)

►

Issue 621467 link

Issue metadata

need to specify button text, outline and focus ring colors for incognito download shelf

Issue description

Comment 1 by vvishwak...@etouch.net, Jun 20 2016

Comment 1 Deleted

Comment 2 by tkonch...@chromium.org, Jun 20 2016

Comment 2 Deleted

Comment 3 by est...@chromium.org, Jun 20 2016

Comment 3 Deleted

Comment 4 by est...@chromium.org, Jun 20 2016

Comment 4 Deleted

Comment 5 by est...@chromium.org, Jun 21 2016

Comment 5 Deleted

Comment 6 by est...@chromium.org, Jun 21 2016

Comment 6 Deleted

Comment 7 by est...@chromium.org, Jun 22 2016

Comment 7 Deleted

Comment 8 by sgabr...@chromium.org, Jun 22 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Jun 23 2016

Comment 9 Deleted

Comment 10 by est...@chromium.org, Jun 24 2016

Comment 10 Deleted

Sign in to add a comment