New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621467 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

need to specify button text, outline and focus ring colors for incognito download shelf

Reported by vvishwak...@etouch.net, Jun 20 2016

Issue description

Version: 53.0.2773.0 (Official Build) ced2fcee2c85702055d028f4e3e48c5a75a7e41c-refs/heads/master@{#400610} (32/64-bit)
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
1) Launch chrome, open a New Incognito window and save any webpage.
2) In Downloads shelf at bottom observe the 'Show all' button.

'Show all' button is not visible in Downloads shelf.

'Show all' button should be visible in Downloads shelf.

This is a Regression issue broken in M-53, will soon update other info.

 
Cc: pbomm...@chromium.org
Labels: hasbisect
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Manual bisect:
Good build: 53.0.2770.0 
Bad build: 53.0.2772.0 

Narrow bisect URL:
https://chromium.googlesource.com/chromium/src/+log/c4dd4ff0308ae28239a0a18d7374691fbb3ff1e8..f2eb108ab1e65962104bfde275743369b0e7665b?pretty=fuller&n=10000

Suspecting: r400511

Note: Issue is not seen on Linux and Mac OS.

Incognito_downloads.jpg
60.7 KB View Download
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression

Comment 3 by est...@chromium.org, Jun 20 2016

Cc: est...@chromium.org
 Issue 621482  has been merged into this issue.

Comment 4 by est...@chromium.org, Jun 20 2016

Cc: sgabr...@chromium.org
Labels: OS-Linux
Summary: need to specify button text, outline and focus ring colors for incognito download shelf (was: Regression: In Incognito mode, Show all button in Downloads shelf is not visible.)

Comment 5 by est...@chromium.org, Jun 21 2016

 Issue 622079  has been merged into this issue.

Comment 6 by est...@chromium.org, Jun 21 2016

Owner: sgabr...@chromium.org
Sebastien to provide incognito styling for this button. Assign back to me for implementation.

Comment 7 by est...@chromium.org, Jun 22 2016

similar problem when using custom themes
dlshelf.png
527 KB View Download
Owner: est...@chromium.org
Updated the spec to include buttons on dark theme/incognito. 
See: https://drive.google.com/a/google.com/folderview?id=0B6x6iYCtKinERVJ6WjNCV21SSmM&usp=sharing

Spec name: SPEC-secondary-UI-01b-buttons-dark-theme.png
Status: Fixed (was: Assigned)

Sign in to add a comment