Drmemory tests with file choosers seem to fail. |
|||||||
Issue descriptionTest introduced in https://codereview.chromium.org/2062523002/ First failing build: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%281%29/builds/8084 Sample output: CrossSiteTransferTest.PostWithFileData: c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(458): error: Value of: delegate->file_chosen() Actual: false Expected: true [2980:4872:0617/180652:2750297:WARNING:render_frame_host_impl.cc(1927)] OnDidStopLoading was called twice. c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(480): error: Value of: ChildProcessSecurityPolicyImpl::GetInstance()->CanReadFile( new_process_id, file_path) Actual: false Expected: true c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(490): error: Value of: actual_page_body Expected: has substring "test-file-content" Actual: "------WebKitFormBoundary8oQLaVhRjyBKYRPr\nContent-Disposition: form-data; name=\"file\"; filename=\"\"\nContent-Type: application/octet-stream\n\n\n------WebKitFormBoundary8oQLaVhRjyBKYRPr--\n\n" c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(492): error: Value of: actual_page_body Expected: has substring "3488.tmp" Actual: "------WebKitFormBoundary8oQLaVhRjyBKYRPr\nContent-Disposition: form-data; name=\"file\"; filename=\"\"\nContent-Type: application/octet-stream\n\n\n------WebKitFormBoundary8oQLaVhRjyBKYRPr--\n\n"
,
Jun 21 2016
So far I have not been able to repro. I have tried my usual build configs on Linux and Windows (100 iterations of the test). I have also tried the build config that I believe was used on the failing bot [1] (also 100 iterations). [1] https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%20Builder%20%28DrMemory%29/builds/17303/steps/runhooks/logs/stdio GYP_DEFINES=build_for_tool=drmemory component=shared_library
,
Jun 21 2016
This issue is not related to memory management - the issue is that in the following code:
std::unique_ptr<FileChooserDelegate> delegate(
new FileChooserDelegate(file_path));
shell()->web_contents()->SetDelegate(delegate.get());
EXPECT_TRUE(ExecuteScript(shell()->web_contents(),
"document.getElementById('file').click();"));
EXPECT_TRUE(delegate->file_chosen());
The final assert (delegate->file_chosen()) fails. Interestingly the same pattern is used in 2 other tests (in RenderFrameHostManagerTest). And even more interestingly, these tests are listed as exceptions in tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory_win32.txt:
RenderFrameHostManagerTest.RestoreFileAccessForHistoryNavigation
RenderFrameHostManagerTest.RestoreSubframeFileAccessForHistoryNavigation
,
Jun 21 2016
+creis@ (since he authored the 2 tests from #c3).
,
Jun 28 2016
Oops I forgot to put on the proper labels. Added now, hopefully a DrMemory expert can have a look. Those other tests are in the 'unanalyzed failures' section, and have been there for a long long time :(
,
Aug 25 2016
,
Aug 25 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 29 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 20 2016